Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(detection_area)!: add retruction feature #9255

Conversation

yuki-takagi-66
Copy link
Contributor

@yuki-takagi-66 yuki-takagi-66 commented Nov 7, 2024

Description

This PR add a new feature to decide GO/STOP until the ego has velocity.

Related links

autowarefoundation/autoware_launch#1216

How was this PR tested?

psim and tier4 internal tests.

Notes for reviewers

None.

Interface changes

Effects on system behavior

None.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Nov 7, 2024
Copy link

github-actions bot commented Nov 7, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@yuki-takagi-66 yuki-takagi-66 marked this pull request as ready for review November 7, 2024 09:02
@yuki-takagi-66 yuki-takagi-66 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 7, 2024
@github-actions github-actions bot added the type:documentation Creating or refining documentation. (auto-assigned) label Nov 8, 2024
@yuki-takagi-66 yuki-takagi-66 added the tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) label Nov 8, 2024
Signed-off-by: Yuki Takagi <[email protected]>
@yuki-takagi-66 yuki-takagi-66 force-pushed the takagi/detection_area/add-retraction branch from 0fd105c to b798bee Compare November 8, 2024 06:14
@yuki-takagi-66 yuki-takagi-66 merged commit d15b060 into autowarefoundation:main Nov 8, 2024
25 of 26 checks passed
@yuki-takagi-66 yuki-takagi-66 deleted the takagi/detection_area/add-retraction branch November 8, 2024 06:44
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 29.15%. Comparing base (f6bfbbe) to head (b798bee).
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
...avior_velocity_detection_area_module/src/scene.cpp 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9255      +/-   ##
==========================================
- Coverage   29.16%   29.15%   -0.02%     
==========================================
  Files        1336     1341       +5     
  Lines      102980   103034      +54     
  Branches    39946    39950       +4     
==========================================
+ Hits        30034    30037       +3     
- Misses      70047    70097      +50     
- Partials     2899     2900       +1     
Flag Coverage Δ *Carryforward flag
differential 17.33% <75.00%> (?)
total 29.16% <ø> (-0.01%) ⬇️ Carriedforward from f6bfbbe

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants