Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(detection_area)!: add retruction feature #9255

Merged
merged 1 commit into from
Nov 8, 2024

po

b798bee
Select commit
Loading
Failed to load commit list.
Merged

feat(detection_area)!: add retruction feature #9255

po
b798bee
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Nov 8, 2024 in 42s

CodeScene PR Check

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: -0.00 (9.46 -> 9.46)

  • Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method scene.cpp: DetectionAreaModule::modifyPathVelocity

Annotations

Check warning on line 118 in planning/behavior_velocity_planner/autoware_behavior_velocity_detection_area_module/src/scene.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method 

DetectionAreaModule::modifyPathVelocity increases in cyclomatic complexity from 17 to 19, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check notice on line 118 in planning/behavior_velocity_planner/autoware_behavior_velocity_detection_area_module/src/scene.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

ℹ Getting worse: Bumpy Road Ahead 

DetectionAreaModule::modifyPathVelocity increases from 3 to 4 logical blocks with deeply nested code, threshold is one single block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
View more details on CodeScene Delta Analysis