Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of ProjectStructureAndRoles to allow Sub Projects (API families) with multiple API repositories #146

Conversation

hdamker
Copy link
Collaborator

@hdamker hdamker commented Jun 18, 2024

What type of PR is this?

  • enhancement

What this PR does / why we need it:

Update of ProjectStructureAndRoles.md according to the proposal in #142, specifically #142 (comment).

Minor update of ProjectCharter with addition of definition "Repository" and reflecting that Sub Projects and Working Groups can have multiple repositories.

Which issue(s) this PR fixes:

Fixes #142

Special notes for reviewers:

As there are major changes of the "Sub Project" chapter, the diff does not work properly. In addition some sentences are moved into the "Repositories" chapter.

Additional documentation

This section can be blank.

@hdamker hdamker requested a review from a team June 18, 2024 11:34
bigludo7
bigludo7 previously approved these changes Jun 18, 2024
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM/

@MarkusKuemmerle
Copy link
Collaborator

We should add also a section for IdentityAndConsentManagement, this working group is missing

@MarkusKuemmerle
Copy link
Collaborator

Do TSC want do decide only on Sub Projects and Working Groups or on repositories as well? Then the description of the TSC repsonsibilities in the Project Charter has to be adapted too.

@hdamker
Copy link
Collaborator Author

hdamker commented Jun 20, 2024

We should add also a section for IdentityAndConsentManagement, this working group is missing

That isn't in scope of this issue/PR - but thanks for the hint.

Edit: created #147 for this point

@hdamker
Copy link
Collaborator Author

hdamker commented Jun 20, 2024

@MarkusKuemmerle

Do TSC want do decide only on Sub Projects and Working Groups or on repositories as well? Then the description of the TSC repsonsibilities in the Project Charter has to be adapted too.

That is already covered within the ProjectCharter, at least for the case where a new API repository does change the scope of a Sub Project:

  • approving Sub Project proposals (including, but not limited to, incubation, deprecation, and changes to a Sub Project’s scope)

And the description of the API Backlog working group here in the document addresses that as well:

The responsibility of the Working Group is to coordinate and prepare all the material needed to evaluate a proposal for a new Sub Project (consisting of one or more related APIs), or scope change of an existing Sub Project (including adding additional APIs to that Sub Project)

Adding a repository to a Sub Project for technical reasons without a scope change does not need the approval of the TSC - at least that is my view.

@hdamker hdamker requested review from eric-murray, bigludo7 and a team June 20, 2024 13:49
Deleted line about distinct groups of Contributor, Codeowners, Maintainers between Sub Project.
"API Repository" and "Provider Implementation Repository" as term in uppercase, other types
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM/

@hdamker
Copy link
Collaborator Author

hdamker commented Jul 1, 2024

As decided within last TSC call we are ready to merge here.

@hdamker hdamker merged commit ef048eb into camaraproject:main Jul 1, 2024
@hdamker hdamker deleted the 142-new-proposal-how-to-manage-api-families-as-sub-projects-with-a-set-of-api-family-member-repositories branch July 1, 2024 06:36
hdamker added a commit to camaraproject/Template_API_Repository that referenced this pull request Jul 30, 2024
Changes according to reflect camaraproject/Governance#146
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New proposal how to manage "API Families" as Sub Projects with a set of API "family member" repositories
4 participants