Initial commit of long crossing check

[emersonveenstra]

This is a new analyser that looks for ways with footway=crossing or cycleway=crossing that are over 200 meters long. This happens when people change the tags without splitting the way over the actual crossing part. I haven't found any false positives in the equivalent overpass queries:

way["footway"="crossing"](if: length() > 200)({{bbox}});
(._;>;);
out;

way["cycleway"="crossing"](if: length() > 200)({{bbox}});
(._;>;);
out;

This isn't ready to be merged, I need a little guidance on what to make the item number and level, and what I should do for tests

[Famlam]

I think this is limited to highways, right? Then table {0}highways is probably more efficient?

Note you'll have to import highways and touched_highways, see for example:

osmose-backend/analysers/analyser_osmosis_highway_bad_intersection.py

Lines 88 to 89 in 9fa8a7d

	requires_tables_full = ['highways']
	requires_tables_diff = ['highways', 'touched_highways']

[Famlam]

Nice idea :)
Maybe also interesting to include a waterway crossing (ford=yes or ford=stepping_stones). I recently found one nearby my place. Just an thought that crossed my mind, not sure if really long fords exist somewhere else in the world, so feel free to ignore :)

---

I need a little guidance on what to make the item number and level, and what I should do for tests

Regarding the tests, you can maybe use
https://github.com/osm-fr/osmose-backend/blob/master/analysers/analyser_osmosis_building_in_polygon.py#L80-L97
where you replace "osmosis_building_in_polygon" by the analyser name. (Note that I used proj=23032 there, which corresponds to i.e. NL and Italy)

Then using for example JOSM you can make a .osm file with test cases, for example one highway=footway + footway=crossing of length 50m and one of 250m. Edit the .osm (=XML) file to add timestamp='2014-03-31T22:00:00Z' version='1' to every node/way, and to get positive ID numbers. Example file: https://github.com/osm-fr/osmose-backend/blob/master/tests/osmosis_building_in_polygon.osm

If the "bad" crossing would for example have ID 1234, then use self.check_err(cl="CLASSNUMBER", elems=[("way", "1234")])

[Famlam]

Maybe also add a fix message, describing to split the way when the crossing is over?
Also, don't forget to add a '.' at the end of the detail message :)

[frodrigo]

@emersonveenstra still interested to work on this?

[emersonveenstra]

@frodrigo i probably won't have the time for a while, feel free to take it or give it to someone else

[Famlam]

I might be able to take it over if you prefer, in a week or two. I like the idea

[frodrigo]

Closed in favour of #1992