-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial commit of long crossing check #1764
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
#!/usr/bin/env python | ||
#-*- coding: utf-8 -*- | ||
|
||
########################################################################### | ||
## ## | ||
## Copyright Osmose Contributors 2023 ## | ||
## ## | ||
## This program is free software: you can redistribute it and/or modify ## | ||
## it under the terms of the GNU General Public License as published by ## | ||
## the Free Software Foundation, either version 3 of the License, or ## | ||
## (at your option) any later version. ## | ||
## ## | ||
## This program is distributed in the hope that it will be useful, ## | ||
## but WITHOUT ANY WARRANTY; without even the implied warranty of ## | ||
## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the ## | ||
## GNU General Public License for more details. ## | ||
## ## | ||
## You should have received a copy of the GNU General Public License ## | ||
## along with this program. If not, see <http://www.gnu.org/licenses/>. ## | ||
## ## | ||
########################################################################### | ||
|
||
from modules.OsmoseTranslation import T_ | ||
from .Analyser_Osmosis import Analyser_Osmosis | ||
|
||
sql10 = """ | ||
SELECT | ||
id, | ||
ST_AsText(way_locate(linestring)) | ||
FROM | ||
{0}ways | ||
WHERE | ||
tags != ''::hstore AND | ||
( | ||
(tags?'footway' AND tags->'footway' = 'crossing') OR | ||
(tags?'cycleway' AND tags->'cycleway' = 'crossing') | ||
) AND | ||
ST_Length(linestring::geography) > 200 | ||
""" | ||
|
||
class Analyser_Osmosis_Highway_Long_Crossing(Analyser_Osmosis): | ||
|
||
def __init__(self, config, logger = None): | ||
Analyser_Osmosis.__init__(self, config, logger) | ||
self.classs_change[1] = self.def_class(item = 7800, level = 2, tags = ['tag', 'highway', 'fix:survey'], | ||
title = T_('Long Crossing'), | ||
detail = T_( | ||
'''The crossing way is much longer than expected''')) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe also add a |
||
|
||
self.callback10 = lambda res: {"class":1, "data":[self.way_full, self.positionAsText] } | ||
|
||
def analyser_osmosis_full(self): | ||
self.run(sql10.format(""), self.callback10) | ||
|
||
def analyser_osmosis_diff(self): | ||
self.run(sql10.format("touched_"), self.callback10) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is limited to highways, right? Then table
{0}highways
is probably more efficient?Note you'll have to import
highways
andtouched_highways
, see for example:osmose-backend/analysers/analyser_osmosis_highway_bad_intersection.py
Lines 88 to 89 in 9fa8a7d