Long crossing continued #1992
Merged
Long crossing continued #1992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frodrigo
reviewed
Aug 23, 2023
frodrigo
reviewed
Aug 23, 2023
Primarily:
- Use table highways
- Add fix message; show length
- Also detect too long crossings with: path=crossing; ford=*
- Change item to 2090 ('highway crossing')
Famlam
force-pushed
the
long-crossing-continued
branch
from
b5412b7
to
b367b97
Compare
|
This must be the longest (waterway) crossing in OSM :) So far one plausible false positive case (not sure if I would really call it a crossing) https://www.openstreetmap.org/way/922529606 but even that one should at least be split up, because only the southern part is a likely crossing it seems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues on (and replaces) #1764 by @emersonveenstra as discussed.
Implement the feedback given in #1764, and add some minor enhancements of my own liking.
Some results: crossing_long.zip
cc @emersonveenstra