New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚨 Project sunsetting 🌆 #98

Open

dnephin opened this issue Nov 20, 2022 · 6 comments

Labels

Owner

dnephin commented Nov 20, 2022 •

edited

Loading

Hello everyone,

Unfortunately I no longer have the time or motivation to maintain this project. I have not used pre-commit or these hooks in a few years. I never added tests to the project, so it's difficult for me to review and approve pull requests with any confidence. There have been a number of PRs that have broken things for other people. There are still plenty of bugs to fix, and there are frequent requests to publish new releases.

There are already other projects offering pre-commit hooks for Go. You can find a list here: https://pre-commit.com/hooks.html. Some of those seem to offer a lot more than this project.

If someone is really keen on maintaining these hooks I can link to your fork from the README to redirect people to the new fork. Either way, I will likely be archiving this project sometime in the next year.

I'd like to thank everyone who has contributed to this project. I hope it was a reasonably pleasant experience.

The text was updated successfully, but these errors were encountered:

dnephin pinned this issue

dnephin added the Announcement label

dnephin changed the title ~~Project sunsetting~~ 🚨 Project sunsetting

dnephin changed the title ~~🚨 Project sunsetting~~ 🚨 Project sunsetting 🌆

dnephin mentioned this issue

Create more tags/releases #59

Closed

trallnag commented Nov 22, 2022

Did you stop using Git hooks altogether?

Owner Author

dnephin commented Nov 22, 2022

Yes, I don't really use git hooks anymore. I'll run tests on every file save, and my IDE mostly takes care of formatting and import order every time a file is save. I might do a full test run and lint before committing, but I run it manually. CI catches anything I missed, but it happens infrequently enough.

trallnag commented Nov 22, 2022

ok, thanks for the insight

guettli commented Dec 21, 2022

@dnephin "tests on every save" This sound interesting. Could you please share how you do this?

Owner Author

dnephin commented Dec 21, 2022

Ya, I get a ton of value from running tests on every save!

I use gotestsum --watch -ftestname -- -count=1. Sometimes if I'm working in a large project I'll add -short or -run=<name> to that command to run a subset of tests in the package.

More details about that here: https://github.com/gotestyourself/gotestsum#run-tests-when-a-file-is-saved

By default this runs only the tests in the package that changed (because generally those are the relevant tests), but if your test suite is fast enough and you want to run every test, you could also use ./... at the end of the command to run everything.

dnephin mentioned this issue

feat: Go workspaces support #100

Open

acald-creator mentioned this issue

[CI] Golang Precommit hooks meshery/meshery#6581

Closed

1 task

tonsV2 commented Feb 12, 2023 •

edited

Loading

Maybe archive and refer to this project instead?

amolkahat added a commit to amolkahat/glance-operator that referenced this issue


          Run pre-commit with make

52345e0

Updating pre-commit hook with make. pre-commit-golang
repo is no longer maintained[1]. Instead of using unmainted
repo we can use make to run pre-commit.

[1] dnephin/pre-commit-golang#98

Signed-off-by: Amol Kahat <[email protected]>

amolkahat mentioned this issue

Run pre-commit with make openstack-k8s-operators/glance-operator#171

Merged

amolkahat added a commit to amolkahat/heat-operator that referenced this issue


          Run pre-commit with make

0561f33

Updating pre-commit hook with make. pre-commit-golang
repo is no longer maintained[1]. Instead of using
unmaintained repo we can use make to run pre-commit.

[1] dnephin/pre-commit-golang#98

Signed-off-by: Amol Kahat <[email protected]>

amolkahat mentioned this issue

Run pre-commit with make openstack-k8s-operators/heat-operator#19

Merged

amolkahat added a commit to amolkahat/ironic-operator that referenced this issue


          Run pre-commit with make

43c7896

Updating pre-commit hook with make. pre-commit-golang
repo is no longer maintained[1]. Instead of using
unmaintained repo we can use make to run pre-commit.

[1] dnephin/pre-commit-golang#98

Signed-off-by: Amol Kahat <[email protected]>

amolkahat mentioned this issue

Run pre-commit with make openstack-k8s-operators/ironic-operator#139

Merged

amolkahat added a commit to amolkahat/keystone-operator that referenced this issue


          Run pre-commit with make

Updating pre-commit hook with make. pre-commit-golang
repo is no longer maintained[1]. Instead of using
unmaintained repo we can use make to run pre-commit.

[1] dnephin/pre-commit-golang#98

amolkahat mentioned this issue

Run pre-commit with make openstack-k8s-operators/keystone-operator#202

Merged

amolkahat added a commit to amolkahat/mariadb-operator that referenced this issue


          Run pre-commit with make

c84eaec

Updating pre-commit hook with make. pre-commit-golang
repo is no longer maintained[1]. Instead of using
unmaintained repo we can use make to run pre-commit.

[1] dnephin/pre-commit-golang#98

Signed-off-by: Amol Kahat <[email protected]>

amolkahat mentioned this issue

Run pre-commit with make openstack-k8s-operators/mariadb-operator#79

Merged

amolkahat added a commit to amolkahat/neutron-operator that referenced this issue


          Run pre-commit with make

30206a5

Updating pre-commit hook with make. pre-commit-golang
repo is no longer maintained[1]. Instead of using
unmaintained repo we can use make to run pre-commit.

[1] dnephin/pre-commit-golang#98

Signed-off-by: Amol Kahat <[email protected]>

amolkahat mentioned this issue

Run pre-commit with make openstack-k8s-operators/neutron-operator#124

Merged

amolkahat added a commit to amolkahat/neutron-operator that referenced this issue


          Run pre-commit with make

b98e545

Updating pre-commit hook with make. pre-commit-golang
repo is no longer maintained[1]. Instead of using
unmaintained repo we can use make to run pre-commit.

[1] dnephin/pre-commit-golang#98

Signed-off-by: Amol Kahat <[email protected]>

amolkahat added a commit to amolkahat/nova-operator that referenced this issue


          Run pre-commit with make

1d97c29

Updating pre-commit hook with make. pre-commit-golang
repo is no longer maintained[1]. Instead of using
unmaintained repo we can use make to run pre-commit.

[1] dnephin/pre-commit-golang#98

amolkahat mentioned this issue

Run pre-commit with make openstack-k8s-operators/nova-operator#269

Merged

amolkahat added a commit to amolkahat/openstack-operator that referenced this issue


          Run pre-commit with make

Updating pre-commit hook with make. pre-commit-golang
repo is no longer maintained[1]. Instead of using
unmaintained repo we can use make to run pre-commit.

[1] dnephin/pre-commit-golang#98

amolkahat mentioned this issue

Run pre-commit with make openstack-k8s-operators/openstack-operator#204

Merged

amolkahat added a commit to amolkahat/neutron-operator that referenced this issue


          Run pre-commit with make

5759d9a

Updating pre-commit hook with make. pre-commit-golang
repo is no longer maintained[1]. Instead of using
unmaintained repo we can use make to run pre-commit.

[1] dnephin/pre-commit-golang#98

Signed-off-by: Amol Kahat <[email protected]>

amolkahat added a commit to amolkahat/mariadb-operator that referenced this issue


          Run pre-commit with make

222551a

Updating pre-commit hook with make. pre-commit-golang
repo is no longer maintained[1]. Instead of using
unmaintained repo we can use make to run pre-commit.

[1] dnephin/pre-commit-golang#98

Signed-off-by: Amol Kahat <[email protected]>

amolkahat added a commit to amolkahat/keystone-operator that referenced this issue


          Run pre-commit with make

a7d922c

Updating pre-commit hook with make. pre-commit-golang
repo is no longer maintained[1]. Instead of using
unmaintained repo we can use make to run pre-commit.

[1] dnephin/pre-commit-golang#98

amolkahat mentioned this issue

Run pre-commit with make openstack-k8s-operators/ovn-operator#25

Merged

amolkahat added a commit to amolkahat/nova-operator that referenced this issue


          Run pre-commit with make

89e32db

Updating pre-commit hook with make. pre-commit-golang
repo is no longer maintained[1]. Instead of using
unmaintained repo we can use make to run pre-commit.

[1] dnephin/pre-commit-golang#98

amolkahat added a commit to amolkahat/openstack-operator that referenced this issue


          Run pre-commit with make

413f49e

Updating pre-commit hook with make. pre-commit-golang
repo is no longer maintained[1]. Instead of using
unmaintained repo we can use make to run pre-commit.

[1] dnephin/pre-commit-golang#98

amolkahat added a commit to amolkahat/neutron-operator that referenced this issue


          Run pre-commit with make

dc2e357

Updating pre-commit hook with make. pre-commit-golang
repo is no longer maintained[1]. Instead of using
unmaintained repo we can use make to run pre-commit.

[1] dnephin/pre-commit-golang#98

Signed-off-by: Amol Kahat <[email protected]>

amolkahat added a commit to amolkahat/nova-operator that referenced this issue


          Run pre-commit with make

d00b623

Updating pre-commit hook with make. pre-commit-golang
repo is no longer maintained[1]. Instead of using
unmaintained repo we can use make to run pre-commit.

[1] dnephin/pre-commit-golang#98

amolkahat added a commit to amolkahat/openstack-operator that referenced this issue


          Run pre-commit with make

09f64a5

Updating pre-commit hook with make. pre-commit-golang
repo is no longer maintained[1]. Instead of using
unmaintained repo we can use make to run pre-commit.

[1] dnephin/pre-commit-golang#98

amolkahat added a commit to amolkahat/nova-operator that referenced this issue


          Run pre-commit with make

42ac181

Updating pre-commit hook with make. pre-commit-golang
repo is no longer maintained[1]. Instead of using
unmaintained repo we can use make to run pre-commit.

[1] dnephin/pre-commit-golang#98

amolkahat added a commit to amolkahat/nova-operator that referenced this issue


          Run pre-commit with make

0f9c89d

Updating pre-commit hook with make. pre-commit-golang
repo is no longer maintained[1]. Instead of using
unmaintained repo we can use make to run pre-commit.

[1] dnephin/pre-commit-golang#98

amolkahat added a commit to amolkahat/openstack-operator that referenced this issue


          Run pre-commit with make

2039e44

Updating pre-commit hook with make. pre-commit-golang
repo is no longer maintained[1]. Instead of using
unmaintained repo we can use make to run pre-commit.

[1] dnephin/pre-commit-golang#98

SeanMooney pushed a commit to amolkahat/nova-operator that referenced this issue


          Run pre-commit with make

c190242

Updating pre-commit hook with make. pre-commit-golang
repo is no longer maintained[1]. Instead of using
unmaintained repo we can use make to run pre-commit.

[1] dnephin/pre-commit-golang#98

amolkahat added a commit to amolkahat/nova-operator that referenced this issue


          Run pre-commit with make

88ec221

Updating pre-commit hook with make. pre-commit-golang
repo is no longer maintained[1]. Instead of using
unmaintained repo we can use make to run pre-commit.

[1] dnephin/pre-commit-golang#98

amolkahat added a commit to amolkahat/openstack-operator that referenced this issue


          Run pre-commit with make

d82e2a5

Updating pre-commit hook with make. pre-commit-golang
repo is no longer maintained[1]. Instead of using
unmaintained repo we can use make to run pre-commit.

[1] dnephin/pre-commit-golang#98

amolkahat added a commit to amolkahat/nova-operator that referenced this issue


          Run pre-commit with make

75ad43a

Updating pre-commit hook with make. pre-commit-golang
repo is no longer maintained[1]. Instead of using
unmaintained repo we can use make to run pre-commit.

[1] dnephin/pre-commit-golang#98

amolkahat added a commit to amolkahat/mariadb-operator that referenced this issue


          Run pre-commit with make

c60fea4

Updating pre-commit hook with make. pre-commit-golang
repo is no longer maintained[1]. Instead of using
unmaintained repo we can use make to run pre-commit.

[1] dnephin/pre-commit-golang#98

Signed-off-by: Amol Kahat <[email protected]>

amolkahat added a commit to amolkahat/nova-operator that referenced this issue


          Run pre-commit with make

2e5af0e

Updating pre-commit hook with make. pre-commit-golang
repo is no longer maintained[1]. Instead of using
unmaintained repo we can use make to run pre-commit.

[1] dnephin/pre-commit-golang#98

amolkahat added a commit to amolkahat/openstack-operator that referenced this issue


          Run pre-commit with make

71779f6

Updating pre-commit hook with make. pre-commit-golang
repo is no longer maintained[1]. Instead of using
unmaintained repo we can use make to run pre-commit.

[1] dnephin/pre-commit-golang#98

amolkahat added a commit to amolkahat/nova-operator that referenced this issue


          Run pre-commit with make

4b9e4e8

Updating pre-commit hook with make. pre-commit-golang
repo is no longer maintained[1]. Instead of using
unmaintained repo we can use make to run pre-commit.

[1] dnephin/pre-commit-golang#98

amolkahat added a commit to amolkahat/openstack-operator that referenced this issue


          Run pre-commit with make

a9c0368

Updating pre-commit hook with make. pre-commit-golang
repo is no longer maintained[1]. Instead of using
unmaintained repo we can use make to run pre-commit.

[1] dnephin/pre-commit-golang#98

amolkahat added a commit to amolkahat/openstack-operator that referenced this issue


          Run pre-commit with make

85c25b8

Updating pre-commit hook with make. pre-commit-golang
repo is no longer maintained[1]. Instead of using
unmaintained repo we can use make to run pre-commit.

[1] dnephin/pre-commit-golang#98

amolkahat added a commit to amolkahat/openstack-operator that referenced this issue


          Run pre-commit with make

58208ca

Updating pre-commit hook with make. pre-commit-golang
repo is no longer maintained[1]. Instead of using
unmaintained repo we can use make to run pre-commit.

[1] dnephin/pre-commit-golang#98

martin-majlis-s1 mentioned this issue

Fix failing pre-commit checks scalyr/dataset-go#45

Merged

hangxie mentioned this issue

remove pre-commit hooks for go hangxie/parquet-tools#233

Merged

stefanvanburen added a commit to stefanvanburen/small that referenced this issue


          chore: Remove pre-commit-config.yaml

312eed5

I still think pre-commit is a good idea (for certain things and certain
projects), but don't feel strong enough to maintain this right now, and
dnephin has [sunsetted the project][1].

[1]: dnephin/pre-commit-golang#98

ronensc mentioned this issue

Fix golangci-lint inconsistencies project-codeflare/mcad#110

Merged

4 tasks

dnephin mentioned this issue

support generics #108

Open

dnephin mentioned this issue

pls make a new tag #105

Open

kou mentioned this issue

GH-41887: [Go] Run linter via pre-commit apache/arrow#41888

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment