Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-41887: [Go] Run linter via pre-commit #41888

Merged
merged 13 commits into from
Jun 3, 2024

Conversation

tscottcoombes1
Copy link
Contributor

@tscottcoombes1 tscottcoombes1 commented May 30, 2024

Rationale for this change

Add and run pre-commit

What changes are included in this PR?

Update pre-commit file
Run pre-commit

Are these changes tested?

N/A

Are there any user-facing changes?

No

GitHub Issue: #41887

Copy link

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@tscottcoombes1 tscottcoombes1 changed the title Go pre commit GH-41887: [Go] pre commit May 30, 2024
Copy link

⚠️ GitHub issue #41887 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added awaiting committer review Awaiting committer review awaiting changes Awaiting changes and removed awaiting review Awaiting review awaiting committer review Awaiting committer review labels May 30, 2024
.gitignore Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
@kou kou changed the title GH-41887: [Go] pre commit GH-41887: [Go] Run linter via pre-commit May 30, 2024
@zeroshade
Copy link
Member

It looks like the pre-commit isn't installing goimports you may need to update the CI yaml to manually install it

@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels May 31, 2024
.pre-commit-config.yaml Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the awaiting change review Awaiting change review label May 31, 2024
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels May 31, 2024
.github/workflows/dev.yml Outdated Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Jun 1, 2024
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Jun 1, 2024
.golangci.yaml Outdated Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
@github-actions github-actions bot added awaiting review Awaiting review awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Jun 2, 2024
@github-actions github-actions bot added awaiting review Awaiting review and removed awaiting review Awaiting review awaiting changes Awaiting changes labels Jun 2, 2024
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for pre-commit related configuration changes.

Is it OK for Go related changes?

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Jun 3, 2024
Copy link
Member

@zeroshade zeroshade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@zeroshade zeroshade merged commit 99014ab into apache:main Jun 3, 2024
27 checks passed
@zeroshade zeroshade removed the awaiting merge Awaiting merge label Jun 3, 2024
@github-actions github-actions bot added the awaiting merge Awaiting merge label Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants