Run pre-commit with make #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating pre-commit hook with make. pre-commit-golang repo is no longer maintained[1]. Instead of using unmaintained repo we can use make to run pre-commit. [1] dnephin/pre-commit-golang#98
amolkahat
force-pushed
the
pre_commit_fix
branch
from
4357585
to
a7d922c
Compare
fmount
approved these changes
Feb 23, 2023
amolkahat
added a commit
to amolkahat/release
that referenced
this pull request
Feb 27, 2023
This patch adds pre-commit job for keystone operator. pre-commit job is marked as optional, Job is getting fixed in openstack-k8s-operators/keystone-operator[1]. [1] openstack-k8s-operators/keystone-operator#202 Signed-off-by: Amol Kahat <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, amolkahat, fmount The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-robot
pushed a commit
to openshift/release
that referenced
this pull request
Feb 28, 2023
This patch adds pre-commit job for keystone operator. pre-commit job is marked as optional, Job is getting fixed in openstack-k8s-operators/keystone-operator[1]. [1] openstack-k8s-operators/keystone-operator#202 Signed-off-by: Amol Kahat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating pre-commit hook with make. pre-commit-golang repo is no longer maintained[1]. Instead of using
unmaintained repo we can use make to run pre-commit.
[1] dnephin/pre-commit-golang#98