Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added pre-commit jobs for keystone operator #36005

Merged
merged 1 commit into from
Feb 28, 2023
Merged

Added pre-commit jobs for keystone operator #36005

merged 1 commit into from
Feb 28, 2023

Conversation

amolkahat
Copy link
Contributor

@amolkahat amolkahat commented Feb 3, 2023 •
edited
Loading

This patch adds pre-commit job for keystone operator.
pre-commit job is marked as optional, Job is getting
fixed in openstack-k8s-operators/keystone-operator[1].

[1] openstack-k8s-operators/keystone-operator#202

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 3, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 3, 2023

Hi @amolkahat. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from abays and dprince February 3, 2023 07:28
@openshift-ci-robot
Copy link
Contributor

@amolkahat: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openstack-k8s-operators-glance-operator-master-precommit-check openstack-k8s-operators/glance-operator presubmit Presubmit changed
pull-ci-openstack-k8s-operators-glance-operator-master-gofmt openstack-k8s-operators/glance-operator presubmit Ci-operator config changed
pull-ci-openstack-k8s-operators-glance-operator-master-golangci openstack-k8s-operators/glance-operator presubmit Ci-operator config changed
pull-ci-openstack-k8s-operators-glance-operator-master-golint openstack-k8s-operators/glance-operator presubmit Ci-operator config changed
pull-ci-openstack-k8s-operators-glance-operator-master-govet openstack-k8s-operators/glance-operator presubmit Ci-operator config changed
pull-ci-openstack-k8s-operators-glance-operator-master-unit openstack-k8s-operators/glance-operator presubmit Ci-operator config changed
pull-ci-openstack-k8s-operators-mariadb-operator-master-precommit-check openstack-k8s-operators/mariadb-operator presubmit Presubmit changed
pull-ci-openstack-k8s-operators-mariadb-operator-master-gofmt openstack-k8s-operators/mariadb-operator presubmit Ci-operator config changed
pull-ci-openstack-k8s-operators-mariadb-operator-master-golangci openstack-k8s-operators/mariadb-operator presubmit Ci-operator config changed
pull-ci-openstack-k8s-operators-mariadb-operator-master-golint openstack-k8s-operators/mariadb-operator presubmit Ci-operator config changed
pull-ci-openstack-k8s-operators-mariadb-operator-master-govet openstack-k8s-operators/mariadb-operator presubmit Ci-operator config changed
pull-ci-openstack-k8s-operators-mariadb-operator-master-images openstack-k8s-operators/mariadb-operator presubmit Ci-operator config changed
pull-ci-openstack-k8s-operators-mariadb-operator-master-mariadb-operator-build-deploy openstack-k8s-operators/mariadb-operator presubmit Ci-operator config changed
pull-ci-openstack-k8s-operators-mariadb-operator-master-unit openstack-k8s-operators/mariadb-operator presubmit Ci-operator config changed
pull-ci-openstack-k8s-operators-keystone-operator-master-precommit-check openstack-k8s-operators/keystone-operator presubmit Presubmit changed
pull-ci-openstack-k8s-operators-keystone-operator-master-gofmt openstack-k8s-operators/keystone-operator presubmit Ci-operator config changed
pull-ci-openstack-k8s-operators-keystone-operator-master-golangci openstack-k8s-operators/keystone-operator presubmit Ci-operator config changed
pull-ci-openstack-k8s-operators-keystone-operator-master-golint openstack-k8s-operators/keystone-operator presubmit Ci-operator config changed
pull-ci-openstack-k8s-operators-keystone-operator-master-govet openstack-k8s-operators/keystone-operator presubmit Ci-operator config changed
pull-ci-openstack-k8s-operators-keystone-operator-master-unit openstack-k8s-operators/keystone-operator presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse refresh to get an updated list of affected jobs (useful if you have new pushes to the branch)

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@amolkahat amolkahat changed the title Added pre-commit jobs for glance, keystone and mariadb Added pre-commit jobs for keystone operator Feb 3, 2023
@amolkahat
Copy link
Contributor Author

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 6, 2023
@amolkahat
Copy link
Contributor Author

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@amolkahat, pj-rehearse: failed to create rehearsal jobs ERROR: 'failed to ensure imagestreamtags in cluster build03: failed to check if imagestreamtag /tools:openstack-operator-ci-pre-commit exists: an empty namespace may not be set when a resource name is provided'. If the problem persists, please contact Test Platform.

@amolkahat
Copy link
Contributor Author

/pj-rehearse

@amolkahat
Copy link
Contributor Author

/pj-rehearse pull-ci-openstack-k8s-operators-keystone-operator-master-precommit-check

@amolkahat amolkahat force-pushed the keystone_pre_commit branch 2 times, most recently from 680120c to e581881 Compare February 13, 2023 11:47
@amolkahat
Copy link
Contributor Author

/pj-rehearse

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 14, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 14, 2023
@amolkahat
Copy link
Contributor Author

/pj-rehearse

@amolkahat
Copy link
Contributor Author

/pj-rehearse

@amolkahat amolkahat force-pushed the keystone_pre_commit branch 2 times, most recently from f5fae37 to b8d8aae Compare February 20, 2023 12:19
@amolkahat
Copy link
Contributor Author

/pj-rehearse

@amolkahat
Added pre-commit for keystone
c4b7421 
This patch adds pre-commit job for keystone operator.
pre-commit job is marked as optional, Job is getting
fixed in openstack-k8s-operators/keystone-operator[1].

[1] openstack-k8s-operators/keystone-operator#202

Signed-off-by: Amol Kahat <[email protected]>
@amolkahat
Copy link
Contributor Author

/pj-rehearse

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 27, 2023

@amolkahat: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 27, 2023
@Sandeepyadav93
Copy link
Contributor

/lgtm

https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_release/36005/rehearse-36005-pull-ci-openstack-k8s-operators-keystone-operator-master-precommit-check/1630149834021277696/artifacts/test/build-log.txt

@Sandeepyadav93
Copy link
Contributor

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Feb 28, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amolkahat, dprince, Sandeepyadav93

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit c182c53 into openshift:master Feb 28, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 28, 2023

@amolkahat: Updated the following 2 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openstack-k8s-operators-keystone-operator-master.yaml using file ci-operator/config/openstack-k8s-operators/keystone-operator/openstack-k8s-operators-keystone-operator-master.yaml
  • job-config-master-presubmits configmap in namespace ci at cluster app.ci using the following files:
    • key openstack-k8s-operators-keystone-operator-master-presubmits.yaml using file ci-operator/jobs/openstack-k8s-operators/keystone-operator/openstack-k8s-operators-keystone-operator-master-presubmits.yaml

In response to this:

This patch adds pre-commit job for keystone operator.
pre-commit job is marked as optional, Job is getting
fixed in openstack-k8s-operators/keystone-operator[1].

[1] openstack-k8s-operators/keystone-operator#202

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dprince dprince dprince approved these changes

@abays abays Awaiting requested review from abays

Assignees

@dprince dprince

@Sandeepyadav93 Sandeepyadav93

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@amolkahat @openshift-ci-robot @Sandeepyadav93 @dprince @openshift-merge-robot