Fix golangci-lint inconsistencies #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Golangci-lint will be installed on the fly while running pre-commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
fixes #108
What changes have been made
$PATH.v1.54.2->v1.55.2Setup golangci-lintstep frommcad-CIsince the new definition of the golangci-lint hook installs it on the fly.BTW, the other golang pre-commit hooks are taken from a repo that is sunset. I would recommend taking these hooks from a different repo which is still maintained.
dnephin/pre-commit-golang#98
Verification steps
Checks