feat: change the old diagnostic_convertor to scenario_simulator_v2_adapter #1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitsudome-r
requested review from
takayuki5168,
rej55,
satoshi-ota,
shmpwk and
yukkysaito
as code owners
github-actions
bot
added
component:simulation
…apter Signed-off-by: xtk8532704 <[email protected]>
mitsudome-r
force-pushed
the
scenario-simulator-v2-adapter
branch
from
4ce70d3
to
567f5b3
Compare
takayuki5168
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Autoware Launch in the main branch currently fails to launch due to lack of argument to
launch_scenario_simulator_v2_adapter. This is caused by the change of argument name in Autoware.Universe in this PR.This resolved this issue by updating the argument name appropriately.
Tests performed
I have tested in my local machine that it works after updating the argument name.
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.