fix(setup): merge configuration inside harpoon.setup()
#557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of initializing the users configuration inside `harpoon:new()`,
do it when `harpoon:setup({})` is called. This fixes the issue, when
using the `settings.key`-function for the setup-call.
|
Great, I can take this from here |
In order to minimize this PR, some changes have been reverted. The issue is not about merging the config, but initializing the data.
|
This reverts some changes, to make it more minimal, which also lets the tests pass now. |
|
@ThePrimeagen Hi! |
|
Currently running into issues with this as well, would love to see this merged 🙏 :) |
|
+1 |
metalinspired
added a commit
to metalinspired/harpoon
that referenced
this pull request
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of initializing the users configuration inside
harpoon:new(), do it whenharpoon:setup({})is called. This fixes the issue, when using thesettings.key-function for the setup-call.This change brakes one of the testies :\