Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stopped working with git-worktree #551

Open
wintermonth2298 opened this issue Apr 4, 2024 · 6 comments
Open

Stopped working with git-worktree #551

wintermonth2298 opened this issue Apr 4, 2024 · 6 comments

Comments

@wintermonth2298
Copy link

Saves only files added from the project root. Even though the key is returned with the correct path (the path to the folder with the branch).

How to reproduce?

  1. Select a branch using git-worktree.
  2. Add an entry to harpoon.
  3. Close nvim
  4. Open nvim and select the desired branch using git-worktree

The recordings will not be saved.

The problem appeared after today's update

@ThePrimeagen
Copy link
Owner

When did you update? Can you make sure you pull one more time? I added some updates to make it so we save files continuously, not just on closing

@wintermonth2298
Copy link
Author

wintermonth2298 commented Apr 4, 2024

I'm on last commit 2e25a13. The previous update was a few days ago.

@wintermonth2298
Copy link
Author

wintermonth2298 commented Apr 4, 2024

You can test this behaviour by :lcd/cd to any dir in project and adding file to harpoon, then reopen nvim, :cd/lcd same dir and open harpoon.

@ThePrimeagen
Copy link
Owner

@wintermonth2298 there has been SEVERAL commits since a few days ago. you may want to update. there has been MANY of fixes. i am using harpoon wildly often

@floork
Copy link

floork commented Apr 5, 2024

Can confirm still not working (I am on the latest version)

@kimabrandt-flx
Copy link

kimabrandt-flx commented Apr 6, 2024

I made an attempt of fixing this issue in #557. It'll break one of your testies, but maybe it can be helpful to solve this issue!?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants