Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(setup): merge configuration inside harpoon.setup() #557

Open
wants to merge 2 commits into
base: harpoon2
Choose a base branch
from
Open

fix(setup): merge configuration inside harpoon.setup() #557

wants to merge 2 commits into from

Commits on Apr 6, 2024

  1. fix(setup): merge configuration inside harpoon.setup() 

    Instead of initializing the users configuration inside `harpoon:new()`,
do it when `harpoon:setup({})` is called. This fixes the issue, when
using the `settings.key`-function for the setup-call.
    @kimabrandt-flx
    kimabrandt-flx committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    81221b6 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2024

  1. refactor: revert and minimize some changes 

    In order to minimize this PR, some changes have been reverted. The issue
is not about merging the config, but initializing the data.
    @kimabrandt-flx
    kimabrandt-flx committed Apr 13, 2024
    Configuration menu
    Copy the full SHA
    a603338 View commit details
    Browse the repository at this point in the history