-
-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][IMP]delivery_delivery_package_fee delivery_automatic_package delivery_package_number simplify tests #854
base: 16.0
Are you sure you want to change the base?
Conversation
5ecff2a
to
f54d349
Compare
f54d349
to
c0fff8b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM code review
Thx. It would be great to move forward with this. I hunger for it :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Is it ok to break the current implementation of delivery_roulier?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with the delivery_package_number
part. Thanks :)
because it's not anymore in base_delivery_carrier_label
because it's not anymore in base_delivery_carrier_label
because it's not anymore in base_delivery_carrier_label
c0fff8b
to
556fdaa
Compare
Now that the depend pr is merged; this one is ready. |
Simplify tests by removing the now useless context key.
Includes:
Tests only pass if we have all the commit (this PR).