[16.0][BC] base_delivery_carrier_label: remove _set_a_default_package #853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This functionality adds a burden on other modules tests like (delivery_package_fee or delivery_package_number). In some context, you want to require a package to always explicitly created. This functionality is also now implemented in delivery_automatic_package.
This was referenced Jul 9, 2024
|
@rousseldenis please have a look. It remplace #643 |
florian-dacosta
approved these changes
Jul 9, 2024
|
@hparfr Could you fix also roulier module here ? |
|
@rousseldenis is it possible to |
I think so |
Because, base_delivery_carrier_label do not create packs automatically anymore, we have to create a pack in delivery_roulier_tests Delivery roulier still can't work without pack. Also, add myself as a maintainer of the module.
|
@rousseldenis |
|
@rousseldenis is it ok for you to merge this PR ? |
|
@rousseldenis I'm waiting your feedback here. |
rousseldenis
approved these changes
Sep 23, 2024
|
/ocabot merge major |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 025b059. Thanks a lot for contributing to OCA. ❤️ |
hparfr
deleted the
16.0-fix-base_delivery_label-automatic-pack-creation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This functionality adds a burden on other modules tests like (delivery_package_fee or delivery_package_number).
In some contexts, you want to require a package to be always explicitly created.
This functionality is also now implemented in
delivery_automatic_packagemodule.To be merged with
majorEDIT:
Contains and replace:
This PR remove set_a_default_package from base_delivery_carrier_label.Tests are red because it needs some changes in delivery_roulier #855
And tests in #855 are also red because it needs this PR.