[14.0][FIX] Unittests base_delivery_carrier_label: Separate github test run #786
Conversation
mt-software-de
force-pushed
the
fix_test_cases_base_delivery_carrier_label
branch
from
eab448d
to
e81b8cf
Compare
PR OCA#786 should merged first [FIX] Unittests base_delivery_carrier_label: Separate github test run For dependents addons
mt-software-de
force-pushed
the
fix_test_cases_base_delivery_carrier_label
branch
from
46ba3c2
to
7ced30f
Compare
|
cc @chienandalu @jbaudoux |
PR: OCA#786 [FIX] Unittests base_delivery_carrier_label: Separate github test run For dependents addons
mt-software-de
force-pushed
the
fix_test_cases_base_delivery_carrier_label
branch
from
5dfa113
to
d5d26b3
Compare
|
@mt-software-de Can you drop generated files from your commits? It makes migration easier, preventing cherry-pick conflicts |
|
@mt-software-de Have you looked at #643 ? I've externalized the automatic package creation in order to not depend on that on base module (in specific ones if needed) |
mt-software-de
force-pushed
the
fix_test_cases_base_delivery_carrier_label
branch
2 times, most recently
from
55bfc88
to
53f9c98
Compare
mt-software-de
changed the title
done |
|
Can we merge this one? |
ping @jbaudoux, @rousseldenis is it possible to merge this one? |
|
This PR i blocking a few others. |
|
@OCA/logistics-maintainers ? |
Otherwise in a scenario with a transfer including moves with packages and without the wrong amount of pieces is send Therefore also the dependency to delivery_package_number can be removed
mt-software-de
force-pushed
the
fix_test_cases_base_delivery_carrier_label
branch
from
53f9c98
to
01d4b88
Compare
|
One Last try Ping @jbaudoux? :-) |
| - container: ghcr.io/oca/oca-ci/py3.6-ocb14.0:latest | ||
| name: test with OCB | ||
| makepot: "true" | ||
| exclude: "base_delivery_carrier_label,delivery_carrier_label_batch,delivery_roulier,delivery_roulier_option,delivery_roulier_laposte_fr,delivery_roulier_chronopost_fr,carrier_account_environment" |
There was a problem hiding this comment.
Wait, this is going to slow down builds a lot.
Don't we have any better way to handle this? Normally this happens because modules tend to enable features by default. Can't we don anything to prevent that?
There was a problem hiding this comment.
Yes but there is No Progress and No Response. See #643
There was a problem hiding this comment.
Could we please merge this for now. I really waiting on this. If there is anyone which refactors the false implemented addon base_delivery_carrier_label, also the test flow can be changed again.
There was a problem hiding this comment.
ping
Also #643 will created separate github flow runs.
There was a problem hiding this comment.
@mt-software-de Please have a look to #854
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
Since base_delivery_carrier_label introduced a logic,
to a default stock.quant.package on stock.move.lines.
We always have to deal with it, in other not dependent addons.
The context key
set_default_packageis used in multiple modules which do not have a dependency to base_delivery_carrier_label