Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14][ADD] delivery_schenker_quant_package_dimension: Length Width Height #801

Merged
merged 2 commits into from
May 18, 2024
Merged

[14][ADD] delivery_schenker_quant_package_dimension: Length Width Height #801

merged 2 commits into from
May 18, 2024

Conversation

mt-software-de
Copy link
Contributor

@mt-software-de mt-software-de commented Apr 22, 2024 •
edited
Loading

I extracted the volume extension from delivery_schenker into an own addon
and added as well the missing fields for Length Width and Height.

cc @chienandalu @jbaudoux

@mt-software-de mt-software-de mentioned this pull request Apr 22, 2024
Open
@mt-software-de
Copy link
Contributor Author

@chienandalu, @raumschmiede-joshuaL maybe you can give this one a review?

chienandalu
chienandalu reviewed May 17, 2024
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mt-software-de

We don't maintain this module at the moment, so maybe I'm not the right one to review this one.

@mt-software-de
Copy link
Contributor Author

Hi @mt-software-de

We don't maintain this module at the moment, so maybe I'm not the right one to review this one.

Oh yes my fault.

@mt-software-de
Copy link
Contributor Author

Maybe @hildickethan-S73 ?

hildickethan
hildickethan approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@hildickethan hildickethan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@mt-software-de
[ADD] delivery_schenker_quant_package_dimension:
69a165d 
Glue addon between delivery_schenker and stock_quant_package_dimension
Using the package.volume and all dimension to transmit to schenker
@mt-software-de
Copy link
Contributor Author

@jbaudoux could you merge this one?

@dreispt
Copy link
Member

dreispt commented May 18, 2024

/ocabot merge major

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-801-by-dreispt-bump-major, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit f1ac1b0 into OCA:14.0 May 18, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d1bde1e. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chienandalu chienandalu chienandalu left review comments

@raumschmiede-joshuaL raumschmiede-joshuaL raumschmiede-joshuaL approved these changes

@hildickethan hildickethan hildickethan approved these changes

@jbaudoux jbaudoux jbaudoux approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mt-software-de @OCA-git-bot @dreispt @chienandalu @jbaudoux @hildickethan @raumschmiede-joshuaL