-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Ramble modifier to fill in allocation variables #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
experiment
New or modified experiment
configs
New or modified system config
labels
Apr 3, 2024
scheibelp
commented
Apr 3, 2024
scheibelp
commented
Apr 4, 2024
scheibelp
commented
Apr 4, 2024
Example script generated from
|
pearce8
reviewed
Apr 4, 2024
pearce8
reviewed
Apr 4, 2024
pearce8
reviewed
Apr 4, 2024
pearce8
reviewed
Apr 4, 2024
pearce8
reviewed
Apr 4, 2024
pearce8
reviewed
Apr 4, 2024
pearce8
reviewed
Apr 4, 2024
pearce8
reviewed
Apr 4, 2024
pearce8
reviewed
Apr 4, 2024
nhanford
reviewed
May 14, 2024
…n to avoid doing concretization/install as part of ramble workspace setup)
3 tasks
pearce8
approved these changes
Jun 6, 2024
This was referenced Jun 8, 2024
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci
Involving Project CI & Unit Tests
configs
New or modified system config
experiment
New or modified experiment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #178
Fixes #221
Given an experiment that requests resources (nodes, cpus, gpus, etc.) and a system description (cpus-per-node, gpus-per-node, etc.) this intends to generate an appropriate scheduler request for resources. In some cases that ends up determining things like how many nodes are desired for a given benchmark.
#178 (comment) brings up some more-interesting examples like these, and this PR is an alternative approach.
This requires a newer Ramble than what Benchpark currently uses by default (right now I'm using
https://github.com/GoogleCloudPlatform/ramble/pull/452
).Remaining work:
execute_experiment.tpl
filesexperiments/saxpy/openmp
andconfigs/nosite-x86_64
are changed to demonstrate the organization)experiment/*/*/ramble.yaml
files have been translated, but need further updates to actually describe system resources (e.g. number of GPUs on each node etc.)ramble workspace setup --dry-run
of some configs and experiments: this actually runs the modifier defined here to generate batch scripts etc. with all resource requests filled inTesting:
You can run any one of the following on any system
For the
ramble workspace setup
command it tells you to run, just append--phases make_experiments
to the end of it (that will skip the concretize/install steps).Oddities:
execute_experiment.tpl
files are slightly different than the others: they have an extra{experiment_setup}
; everything sets that variable to''
though, so I don't see a problem with removing them as wellSome values must be defined before the modifier runs, e.g. n_ranks. I've arbitrarily decided the placeholder value for these is "7" (they must be positive integers, so I decided to choose a number that was (a) unlikely to be explicitly chosen and (b) small (in case they percolate to actual requests)