Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding pre and post processing options which are unrelated to the ind… #258

Closed
wants to merge 1 commit into from

Conversation

jdomke
Copy link
Collaborator

@jdomke jdomke commented Jun 1, 2024

…ividual benchmark

the issue is that fujitsu-mpi does not redirect to stdout, and on fugaku a usual workaround via -of|-std flags is currently disabled by the ops team and therefore we can at best redirect to a merged file of stdout+strerr for each rank via -std-proc

so, the general ramble approach of mpi_command exec >> log_file does not work; pre_cmd and post_cmd don't work either, because they are part of the benchmark or part of a modifier (which isnt the case for an mpi)

currently, only way i see to add this is via these pre_process and post_process variables which might be useful for others in the future, too

redirect mpi output on fugaku

…ividual benchmark

the issue is that fujitsu-mpi does not redirect to stdout, and on
fugaku a usual workaround via -of|-std flags is currently disabled
by the ops team and therefore we can at best redirect to a merged
file of stdout+strerr for each rank via -std-proc

so, the general ramble approach of `mpi_command exec >> log_file`
does not work; pre_cmd and post_cmd don't work either, because
they are part of the benchmark or part of a modifier (which isnt
the case for an mpi)

currently, only way i see to add this is via these pre_process
and post_process variables which might be useful for others in the
future, too

redirect mpi output on fugaku
@github-actions github-actions bot added experiment New or modified experiment configs New or modified system config labels Jun 1, 2024
@pearce8 pearce8 requested a review from scheibelp June 5, 2024 02:03
@scheibelp scheibelp self-assigned this Jun 7, 2024
@scheibelp
Copy link
Collaborator

I'm currently working on a PR to address the conflicts here as well as add a few other conveniences on top of #195. I should have it ready by end of Monday (June 10th)

scheibelp added a commit to scheibelp/benchpark that referenced this pull request Jun 11, 2024
@pearce8
Copy link
Collaborator

pearce8 commented Jun 25, 2024

@jdomke Please test to check if the newly merged PR addresses the issue you were solving in this PR. (#276)

pearce8 pushed a commit that referenced this pull request Jun 25, 2024
* show example of not using allocation modifier

* restore test config

* I was hoping I could expand variables into lists; but I don't think that will work

* variable naming consistency

* refactor as multi-line strings vs string lists

* add test config; demonstrates an odd behavior for expansion of multi-line strings

* expand test config

* needed for emulating #258

* missing space

* style fix

* style fix 2

* forgot to re-add argument with new format

* relocate execute_experiment template
@pearce8 pearce8 closed this in #276 Jun 25, 2024
daboehme pushed a commit that referenced this pull request Jul 10, 2024
* show example of not using allocation modifier

* restore test config

* I was hoping I could expand variables into lists; but I don't think that will work

* variable naming consistency

* refactor as multi-line strings vs string lists

* add test config; demonstrates an odd behavior for expansion of multi-line strings

* expand test config

* needed for emulating #258

* missing space

* style fix

* style fix 2

* forgot to re-add argument with new format

* relocate execute_experiment template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
configs New or modified system config experiment New or modified experiment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants