Bugfix/tags #288
Merged
Bugfix/tags #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… other commands get confused by putting non-experiment resources in that dir
github-actions
bot
added
docs
pearce8
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #286
With these changes, I can run
python3 generate-benchmark-list.py <workspace>(note this script appears to expect that it is run from<benchpark>/docs/).<benchpark>/experiments/universal-resources, which confuses some logic that assumes everything inexperiments/is a name that is defined in Rambledefault_compilertodefine_compilerin Renamedefault_compilertodefine_compilerGoogleCloudPlatform/ramble#428