Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A variety of fixes pulled from the ninja-keys repo #9

Merged
merged 12 commits into from
Feb 15, 2024

Conversation

KonnorRogers
Copy link
Owner

@KonnorRogers KonnorRogers commented Feb 8, 2024

@jwoertink
Copy link

Nice! This is great that you're taking this on. I love the library, but definitely been frustrating not having consistent fixes and updates. Just leaving a comment here so I can watch for when this is merged and give your fork a shot. Thanks!

@KonnorRogers
Copy link
Owner Author

@jwoertink I've actually been maintaining this fork for ~9months starting with this PR here:

ssleptsov/ninja-keys#47

I've been using it in all of my personal sites.

This PR is just additional cleanup and scaffolding up an actual docs site with examples.

https://github.com/KonnorRogers/konnors-ninja-keys/blob/main/CHANGELOG.md#130

Starting at 1.3.0 has the changes I've been adding!

Feel free to open additional issues if there's anything else you'd like to see / you're missing / any bugs!

@jwoertink
Copy link

Sweet. I've been using my own fork, but I'll give yours a shot. Thanks!

@KonnorRogers KonnorRogers merged commit 02d9f4f into main Feb 15, 2024
@KonnorRogers KonnorRogers deleted the konnorrogers/minor-fixes branch February 15, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants