Escape search query regex #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiagorangel1
reviewed
Nov 4, 2023
| @@ -59,6 +59,7 @@ | |||
| }, | |||
| "dependencies": { | |||
| "@material/mwc-icon": "0.25.3", | |||
| "escape-string-regexp": "5.0.0", | |||
There was a problem hiding this comment.
Adding another library would probably make it a bit slower, is there a way to do this without external libraries?
|
It appears this package hasn't had any comments or any releases in ~2 years. I made a fork with quite a few accessibility improvements and other changes noted in the changelog. Adding this to my package as well. Fixed in my fork here: KonnorRogers/konnors-ninja-keys#9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifying a query with a regex special character causes ninja-keys to throw an exception. For example, imagine searching a phone number "+13155550000".
To fix, we escape the search query before constructing the regex.