Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a guard clause for _inputRef #38

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jwoertink
Copy link

@jwoertink jwoertink commented Dec 14, 2022

Fixes #34

It seems in some browsers, this requestAnimationFrame will execute before the ref exists which throws errors around calling .focus() on undefined.

image

@KonnorRogers
Copy link

Fixed here: KonnorRogers/konnors-ninja-keys#9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sometimes there's no value loaded when an animationFrame is requested
2 participants