Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make ftp and socks proxies optional #36

Closed
wants to merge 1 commit into from

Conversation

georgejdli
Copy link
Contributor

(Opening pull requests from master branch to trigger Github actions)

Ran into this issue with 4.13.0.0 when trying to use the firefox driver config:

org.openqa.selenium.SessionNotCreatedException: Could not start a new session. Response code 500. Message: Since Firefox 90 'ftpProxy' is no longer supported

And ran into this on Chrome, Edge, and Firefox driver config where the plugin was not setting the socksVersion in the org.openqa.selenium.Proxy object (default value is null) :

org.openqa.selenium.SessionNotCreatedException: Could not start a new session. Response code 400. Message: invalid argument: entry 0 of 'firstMatch' is invalid
from invalid argument: cannot parse capability: proxy
from invalid argument: 'socksVersion' must be between 0 and 255 

So I dug into the source code and found that there's no way to selectively unset the different protocol proxies to sidestep these issues.

This PR aims to address this issue by allowing the user to unset FTP and SOCKS proxies individually by adding the appropriate check boxes for the user to toggle.

@undera
Copy link
Owner

undera commented Jul 2, 2024

Duplicate of #35

@undera undera marked this as a duplicate of #35 Jul 2, 2024
@undera undera closed this Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants