Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make ftp and socks proxies optional #35

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

georgejdli
Copy link
Contributor

Ran into this issue with 4.13.0.0 when trying to use the firefox driver config:

org.openqa.selenium.SessionNotCreatedException: Could not start a new session. Response code 500. Message: Since Firefox 90 'ftpProxy' is no longer supported

And ran into this on Chrome, Edge, and Firefox driver config where the plugin was not setting the socksVersion in the org.openqa.selenium.Proxy object (default value is null) :

org.openqa.selenium.SessionNotCreatedException: Could not start a new session. Response code 400. Message: invalid argument: entry 0 of 'firstMatch' is invalid
from invalid argument: cannot parse capability: proxy
from invalid argument: 'socksVersion' must be between 0 and 255 

So I dug into the source code and found that there's no way to selectively unset the different protocol proxies to sidestep these issues.

This PR aims to address this issue by allowing the user to unset FTP and SOCKS proxies individually by adding the appropriate check boxes for the user to toggle.

If the maintainers are receptive to this change I'm open to any feedback required to get this PR into an acceptable state for merging.

@undera
Copy link
Owner

undera commented Jul 1, 2024

It looks ok from the code. How did you test it?

@georgejdli
Copy link
Contributor Author

georgejdli commented Jul 1, 2024

It looks ok from the code. How did you test it?

I built the plugin jar and put it in my $JMETER_BIN/lib/ext folder to test out the changes with a sample test plan.

I have preserved the default behavior so the existing test cases all pass.

@undera
Copy link
Owner

undera commented Jul 2, 2024

Sounds good! Thank you

@undera
Copy link
Owner

undera commented Jul 2, 2024

Please do pull from master branch, so the GH Actions build will run

@undera undera merged commit d6a5be8 into undera:master Jul 2, 2024
1 check passed
@georgejdli georgejdli deleted the manual-proxy-fix branch July 2, 2024 13:21
@rbourga
Copy link
Contributor

rbourga commented Jul 10, 2024

Hi Guys,
For this new version to be picked up by plugin manager, you would also need to update jmeter-plugins/site/dat/repo
/jpgc-plugins.json file in the jmeter-plugins repo accordingly with a new version number for the new webdriver together with its appropriate references.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants