make ftp and socks proxies optional #35
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into this issue with 4.13.0.0 when trying to use the firefox driver config:
And ran into this on Chrome, Edge, and Firefox driver config where the plugin was not setting the socksVersion in the org.openqa.selenium.Proxy object (default value is null) :
So I dug into the source code and found that there's no way to selectively unset the different protocol proxies to sidestep these issues.
This PR aims to address this issue by allowing the user to unset FTP and SOCKS proxies individually by adding the appropriate check boxes for the user to toggle.
If the maintainers are receptive to this change I'm open to any feedback required to get this PR into an acceptable state for merging.