Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the IFI tests #2417

Conversation

SamuelTrahanNOAA
Copy link
Collaborator

@SamuelTrahanNOAA SamuelTrahanNOAA commented Aug 27, 2024

Commit Queue Requirements:

  • Fill out all sections of this template.
  • No subcomponent PRs. All sub component pull requests have been reviewed by their code managers.
  • No tests are affected. Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • No tests are affected. Commit 'test_changes.list' from previous step

Description:

Removes the three tests of the inline post with the in-flight icing library (libIFI).

Due to security and intellectual property restrictions, the in-flight icing library (libIFI) tests are only run on Acorn. The library is expected to never be run in the inline post. Continuing to test it that way only adds unnecessary work. (This was decided at an August 27, 2024 meeting between libIFI stakeholders about libIFI testing.) The UPP standalone (offline post) will still be tested with libIFI.

Commit Message:

* UFSWM - remove the IFI tests

Priority:

  • Normal

Git Tracking

UFSWM:

Sub component Pull Requests:

  • None

UFSWM Blocking Dependencies:

  • None

Changes

Regression Test Changes (Please commit test_changes.list):

  • No Baseline Changes (but some tests are removed).

Input data Changes:

  • None.

Library Changes/Upgrades:

  • None.

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@SamuelTrahanNOAA SamuelTrahanNOAA changed the title remove the ifi tests Remove the IFI tests Aug 27, 2024
@SamuelTrahanNOAA
Copy link
Collaborator Author

@jkbk2004 - This is a zero-risk change, so you can safely combine it with anything.

@jkbk2004
Copy link
Collaborator

@SamuelTrahanNOAA Thanks for the note! I think we can reflect this pr to #2395.

zach1221 pushed a commit that referenced this pull request Sep 3, 2024
…Switch to using Aux history files in atm_ds2s_docn_dice test; Remove IFI tests (was #2417) (#2395)

* UFSWM - 
  * CMEPS - fix aux history functionality; sync with ESCOMP
  * UFSWM - use auxiliary history files as input for atm_ds2s_docn_dice; remove the IFI tests
@jkbk2004
Copy link
Collaborator

jkbk2004 commented Sep 3, 2024

merged with #2395

@jkbk2004 jkbk2004 closed this Sep 3, 2024
DavidHuber-NOAA added a commit to DavidHuber-NOAA/ufs-weather-model that referenced this pull request Sep 9, 2024
…r-model into develop

* 'develop' of https://github.com/ufs-community/ufs-weather-model:
  update mom6 to its main repo. 20240824 commit (FMA) (ufs-community#2412)
  Update CMEPS; fix aux history functionality for float variable type; Switch to using Aux history files in atm_ds2s_docn_dice test; Remove IFI tests (was ufs-community#2417) (ufs-community#2395)
  Combination for CCPP-physics ufs-community#213 and ufs-community#218 (H2O scheme refactor and C3/SAS/MYNN fix) (ufs-community#2408)
  Unify CDEPS gfs, cfsr, and gefs datm datamodes + Improve error checking in rt.sh (2388) + Add ability to read increment files on native cubed sphere grid (2304) (ufs-community#2389)
  sync with head of NOAA-EMC UPP develop (ufs-community#2326)
  Allow use of downscaled warmstart files for cpld_control_sfs test (ufs-community#2375)
  update to MOM6 main 20240729 commit (gfdl-to-main-2024-05-31) (ufs-community#2381)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the IFI tests
2 participants