Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CMEPS; fix aux history functionality for float variable type; Switch to using Aux history files in atm_ds2s_docn_dice test; Remove IFI tests (was #2417) #2395

Merged
merged 24 commits into from
Sep 3, 2024
Merged

Update CMEPS; fix aux history functionality for float variable type; Switch to using Aux history files in atm_ds2s_docn_dice test; Remove IFI tests (was #2417) #2395

merged 24 commits into from
Sep 3, 2024

Conversation

DeniseWorthen
Copy link
Collaborator

@DeniseWorthen DeniseWorthen commented Aug 12, 2024 •
edited by zach1221
Loading

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

Sync with ESCOMP, including fix for aux history output from EMC.

Commit Message:

* UFSWM - 
  * CMEPS - fix aux history functionality; sync with ESCOMP
  * UFSWM - use auxiliary history files as input for atm_ds2s_docn_dice; remove the IFI tests

Priority:

  • Normal

Git Tracking

UFSWM:

Sub component Pull Requests:

Changes

Regression Test Changes (Please commit test_changes.list):

  • A new baseline is required for the atm_ds2s_docn_dice test.

Input data Changes:

  • None.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@DeniseWorthen DeniseWorthen marked this pull request as ready for review August 12, 2024 20:31
@DeniseWorthen DeniseWorthen changed the title Update CMEPS; fix aux history functionality for float variable type Update CMEPS; fix aux history functionality for float variable type; Switch to using Aux history files in atm_ds2s_docn_dice test Aug 14, 2024
@DeniseWorthen DeniseWorthen added the Baseline Updates Current baselines will be updated. label Aug 15, 2024
@NickSzapiro-NOAA
Copy link
Collaborator

Can we enable atm_ds2s_docn_dice on wcoss2 and acorn in rt.conf?

@BrianCurtis-NOAA
Copy link
Collaborator

Can we enable atm_ds2s_docn_dice on wcoss2 and acorn in rt.conf?

If you've tested and they work, absolutely

@NickSzapiro-NOAA
Copy link
Collaborator

I don't have active accounts to test on these machines right now. With use_float=.true. as is, testing is to check that sfc*nc and atm*nc look similar between cpld_control_nowave_noaero_p8 and atm_ds2s_docn_dice. I'm happy to look at output if it can be moved but also understand if there is no time.

@jkbk2004 jkbk2004 mentioned this pull request Aug 28, 2024
Closed
14 tasks
@FernandoAndrade-NOAA
Copy link
Collaborator

This PR is next for testing, please sync and bring in the changes from #2417

@DeniseWorthen DeniseWorthen changed the title Update CMEPS; fix aux history functionality for float variable type; Switch to using Aux history files in atm_ds2s_docn_dice test Update CMEPS; fix aux history functionality for float variable type; Switch to using Aux history files in atm_ds2s_docn_dice test; Remove IFI tests (was #2417) Aug 29, 2024
@zach1221 zach1221 added the Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. label Aug 30, 2024
@zach1221 zach1221 added jenkins-ort run ORT testing and removed jenkins-ort run ORT testing labels Aug 30, 2024
@zach1221 zach1221 added hercules-RT Run Hera regression testing derecho-RT Run regression tests on Derecho and removed hercules-RT Run Hera regression testing derecho-RT Run regression tests on Derecho labels Aug 30, 2024
@zach1221
Copy link
Collaborator

zach1221 commented Sep 3, 2024

Testing is complete. We can begin the merging process.

@zach1221 zach1221 merged commit 9ae4f54 into ufs-community:develop Sep 3, 2024
3 checks passed
DavidHuber-NOAA added a commit to DavidHuber-NOAA/ufs-weather-model that referenced this pull request Sep 9, 2024
@DavidHuber-NOAA
Merge branch 'develop' of https://github.com/ufs-community/ufs-weathe…
fb22998 
…r-model into develop

* 'develop' of https://github.com/ufs-community/ufs-weather-model:
  update mom6 to its main repo. 20240824 commit (FMA) (ufs-community#2412)
  Update CMEPS; fix aux history functionality for float variable type; Switch to using Aux history files in atm_ds2s_docn_dice test; Remove IFI tests (was ufs-community#2417) (ufs-community#2395)
  Combination for CCPP-physics ufs-community#213 and ufs-community#218 (H2O scheme refactor and C3/SAS/MYNN fix) (ufs-community#2408)
  Unify CDEPS gfs, cfsr, and gefs datm datamodes + Improve error checking in rt.sh (2388) + Add ability to read increment files on native cubed sphere grid (2304) (ufs-community#2389)
  sync with head of NOAA-EMC UPP develop (ufs-community#2326)
  Allow use of downscaled warmstart files for cpld_control_sfs test (ufs-community#2375)
  update to MOM6 main 20240729 commit (gfdl-to-main-2024-05-31) (ufs-community#2381)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FernandoAndrade-NOAA FernandoAndrade-NOAA FernandoAndrade-NOAA approved these changes

@jkbk2004 jkbk2004 jkbk2004 approved these changes

@BrianCurtis-NOAA BrianCurtis-NOAA Awaiting requested review from BrianCurtis-NOAA

Assignees

@DeniseWorthen DeniseWorthen

@NickSzapiro-NOAA NickSzapiro-NOAA

Labels
Baseline Updates Current baselines will be updated. Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@DeniseWorthen @NickSzapiro-NOAA @BrianCurtis-NOAA @FernandoAndrade-NOAA @zach1221 @jkbk2004 @SamuelTrahanNOAA @epic-cicd-jenkins