Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add driver ens160 #94

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add driver ens160 #94

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions driver-db-schema.json
View file
Open in desktop
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you either edited the schema directly or forgot to commit the changes to the schema in the backend. Could you add the company and categories in backend/src/driver_db/manufacturers.rs and backend/src/driver_db/categories.rs and then re-run the backend as described in the readme?

Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,8 @@
"Adafruit",
"Sparkfun",
"Mikroe",
"BBC"
"BBC",
"DFRobot"
]
},
"Category": {
Expand Down Expand Up @@ -88,6 +89,16 @@
"type": "string",
"const": "Sensor::CO2"
},
{
"description": "Sensors calculating air CO2 concentration from VOC values.",
"type": "string",
"const": "Sensor::eCO2"
},
{
"description": "Sensors measuring general air quality by TVOC.",
"type": "string",
"const": "Sensor::TVOC"
},
{
"description": "Sensors measuring air temperature",
"type": "string",
Expand Down Expand Up @@ -154,6 +165,7 @@
"TI",
"NXP",
"Toshiba",
"ScioSense",
"Sensirion",
"SolomonSystech",
"Unknown"
Expand All @@ -170,7 +182,8 @@
"type": "string",
"enum": [
"StemmaQt",
"MikroBus"
"MikroBus",
"Qwiic"
]
},
"DevBoard": {
Expand Down
34 changes: 34 additions & 0 deletions driver-db/ens160.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
manifest_version = "0.0.1"

[meta]
categories = ["Sensor::TVOC", "Sensor::eCO2"]
datasheets = [
"https://www.sciosense.com/wp-content/uploads/2023/12/ENS160-Datasheet.pdf",
]
manufacturer = "ScioSense"
names = ["ENS160"]
part_numbers = ["ENS160"]

kicad_symbol = ["ENS160-BGLM"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can not find this part in my KiCAD installation. I also think it is missing the library name?


[[dev_boards]]
connections = ["Qwiic", "StemmaQt"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since Qwiic and StammeQt are compatible, should we always list both? Or are there any differences I'm missing?

link = "https://www.adafruit.com/product/5606"
manufacturer = "Adafruit"
name = "Adafruit ENS160 MOX Gas Sensor - Sciosense CCS811 Upgrade - STEMMA QT / Qwiic"

[[dev_boards]]
connections = ["Qwiic", "StemmaQt"]
link = "https://www.adafruit.com/product/5606"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might have missed to add this link.

manufacturer = "Sparkfun"
name = "SparkFun Indoor Air Quality Sensor ENS160 for Arduino Qwiic"

[[dev_boards]]
connections = ["StemmaQt"]
link = "https://www.adafruit.com/product/5606"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same with this link.

manufacturer = "DFRobot"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add this manufacturer to the schema? https://github.com/tweedegolf/drive-rs/blob/main/backend/src/driver_db/boards.rs#L14

name = "Fermion - ENS160 Air Quality Sensor - DFRobot SEN0515"

[interfaces.i2c]
addrs = [0x53]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the chip can have either of two addresses, could you also add the second one (0x52)? (See section 14.1.1 of the datasheet)

interrupt = true