Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add driver ens160 #94

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

teamplayer3
Copy link

Add driver ens160

Copy link
Collaborator

@tdittr tdittr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thank you so much for being the first to add a driver to this listing! It looks like an interesting chip.

I have a few small changes I would like to see before merging this.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you either edited the schema directly or forgot to commit the changes to the schema in the backend. Could you add the company and categories in backend/src/driver_db/manufacturers.rs and backend/src/driver_db/categories.rs and then re-run the backend as described in the readme?


[[dev_boards]]
connections = ["Qwiic", "StemmaQt"]
link = "https://www.adafruit.com/product/5606"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might have missed to add this link.


[[dev_boards]]
connections = ["StemmaQt"]
link = "https://www.adafruit.com/product/5606"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same with this link.

names = ["ENS160"]
part_numbers = ["ENS160"]

kicad_symbol = ["ENS160-BGLM"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can not find this part in my KiCAD installation. I also think it is missing the library name?

[[dev_boards]]
connections = ["StemmaQt"]
link = "https://www.adafruit.com/product/5606"
manufacturer = "DFRobot"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kicad_symbol = ["ENS160-BGLM"]

[[dev_boards]]
connections = ["Qwiic", "StemmaQt"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since Qwiic and StammeQt are compatible, should we always list both? Or are there any differences I'm missing?

name = "Fermion - ENS160 Air Quality Sensor - DFRobot SEN0515"

[interfaces.i2c]
addrs = [0x53]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the chip can have either of two addresses, could you also add the second one (0x52)? (See section 14.1.1 of the datasheet)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants