-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add driver ens160 #94
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thank you so much for being the first to add a driver to this listing! It looks like an interesting chip.
I have a few small changes I would like to see before merging this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you either edited the schema directly or forgot to commit the changes to the schema in the backend. Could you add the company and categories in backend/src/driver_db/manufacturers.rs and backend/src/driver_db/categories.rs and then re-run the backend as described in the readme?
|
||
[[dev_boards]] | ||
connections = ["Qwiic", "StemmaQt"] | ||
link = "https://www.adafruit.com/product/5606" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might have missed to add this link.
|
||
[[dev_boards]] | ||
connections = ["StemmaQt"] | ||
link = "https://www.adafruit.com/product/5606" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same with this link.
names = ["ENS160"] | ||
part_numbers = ["ENS160"] | ||
|
||
kicad_symbol = ["ENS160-BGLM"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can not find this part in my KiCAD installation. I also think it is missing the library name?
[[dev_boards]] | ||
connections = ["StemmaQt"] | ||
link = "https://www.adafruit.com/product/5606" | ||
manufacturer = "DFRobot" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add this manufacturer to the schema? https://github.com/tweedegolf/drive-rs/blob/main/backend/src/driver_db/boards.rs#L14
kicad_symbol = ["ENS160-BGLM"] | ||
|
||
[[dev_boards]] | ||
connections = ["Qwiic", "StemmaQt"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since Qwiic and StammeQt are compatible, should we always list both? Or are there any differences I'm missing?
name = "Fermion - ENS160 Air Quality Sensor - DFRobot SEN0515" | ||
|
||
[interfaces.i2c] | ||
addrs = [0x53] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the chip can have either of two addresses, could you also add the second one (0x52)? (See section 14.1.1 of the datasheet)
Add driver ens160