-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Silicon/Bosc: Add Support pcie driver to NanHuDev #200
Conversation
Please put enough information in the PR title that we can deduce what platforms are impacted from that alone. Then please add some actual description, so that once someone opens the PR, they don't then need to go looking at each individual commit to understand what is being done. |
Thank you very much for the reminder. The title has been updated and a description of the patch's functionality has been added. |
Silicon/Bosc/NanHuPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf
Outdated
Show resolved
Hide resolved
Silicon/Bosc/NanHuPkg/Library/PciHostBridgeLib/PciHostBridgeLib.h
Outdated
Show resolved
Hide resolved
Silicon/Bosc/NanHuPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf
Outdated
Show resolved
Hide resolved
Silicon/Bosc/NanHuPkg/Library/PciHostBridgeLib/PciHostBridgeLib.h
Outdated
Show resolved
Hide resolved
Silicon/Bosc/NanHuPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c
Outdated
Show resolved
Hide resolved
Add bit operated macro,like BIT... Cc: Sunil V L <[email protected]> Cc: Leif Lindholm <[email protected]> Cc: Michael D Kinney <[email protected]> Cc: Daniel Schaefer <[email protected]> Cc: Ray Ni <[email protected]> Cc: Ran Wang <[email protected]> Signed-off-by: Yang Wang <[email protected]>
6764dc4
to
fa5738d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than two minor comments, LGTM.
Pcihostbridgelib uses the general PCD variable. Like PcdPciBusMin PcdPciBusMax ... Cc: Sunil V L <[email protected]> Cc: Leif Lindholm <[email protected]> Cc: Michael D Kinney <[email protected]> Cc: Daniel Schaefer <[email protected]> Cc: Ray Ni <[email protected]> Cc: Ran Wang <[email protected]> Signed-off-by: Yang Wang <[email protected]>
The PCI Segment Library for Bosc NanHuDev platform. Reviewed-by: Evan Chai <[email protected]> Reviewed-by: Ran Wang <[email protected]> Reviewed-by: Jian Zhang <[email protected]> Cc: Sunil V L <[email protected]> Cc: Leif Lindholm <[email protected]> Cc: Michael D Kinney <[email protected]> Cc: Daniel Schaefer <[email protected]> Cc: Ray Ni <[email protected]> Signed-off-by: Yang Wang <[email protected]>
Reviewed-by: Evan Chai <[email protected]> Reviewed-by: Ran Wang <[email protected]> Reviewed-by: Jian Zhang <[email protected]> Cc: Sunil V L <[email protected]> Cc: Leif Lindholm <[email protected]> Cc: Michael D Kinney <[email protected]> Cc: Daniel Schaefer <[email protected]> Cc: Ray Ni <[email protected]> Signed-off-by: Yang Wang <[email protected]>
Cc: Leif Lindholm <[email protected]> Cc: Michael D Kinney <[email protected]> Cc: Sunil V L <[email protected]> Cc: Daniel Schaefer <[email protected]> Signed-off-by: Yang Wang <[email protected]>
fa5738d
to
5f2d2e0
Compare
In order to support PCIe host driver on the Silicon/BOSC NanhuDev platform。
Three patches have been submitted, with the following functions:
7dcf45f: Add PCI Segment Library for Silicon/Bosc NanHuDev platform.
8f8ae61:Add PciHostBridgeLib driver for Silicon/Bosc NanHuDev platform.
6764dc4: Add Support NVME device