Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silicon/Bosc: Add Support pcie driver to NanHuDev #200

Merged
merged 5 commits into from
Oct 24, 2024

Conversation

wangy566
Copy link
Contributor

@wangy566 wangy566 commented Sep 13, 2024

In order to support PCIe host driver on the Silicon/BOSC NanhuDev platform。
Three patches have been submitted, with the following functions:

7dcf45f: Add PCI Segment Library for Silicon/Bosc NanHuDev platform.
8f8ae61:Add PciHostBridgeLib driver for Silicon/Bosc NanHuDev platform.
6764dc4: Add Support NVME device

Reviewed-by: Evan Chai <[email protected]>
Reviewed-by: Ran Wang <[email protected]>
Reviewed-by: Jian Zhang <[email protected]>
Cc: Leif Lindholm <[email protected]>
Cc: Michael D Kinney <[email protected]>
Cc: Sunil V L <[email protected]>
Cc: Daniel Schaefer <[email protected]>
Cc: Ray Ni <[email protected]>

@leiflindholm
Copy link
Member

Please put enough information in the PR title that we can deduce what platforms are impacted from that alone. Then please add some actual description, so that once someone opens the PR, they don't then need to go looking at each individual commit to understand what is being done.

@wangy566 wangy566 changed the title Upstream pcie v2 Silicon/Bosc: Add Support pcie driver to NanHuDev Sep 13, 2024
@wangy566
Copy link
Contributor Author

Please put enough information in the PR title that we can deduce what platforms are impacted from that alone. Then please add some actual description, so that once someone opens the PR, they don't then need to go looking at each individual commit to understand what is being done.

Thank you very much for the reminder. The title has been updated and a description of the patch's functionality has been added.

@wangy566 wangy566 removed their assignment Sep 18, 2024
Add bit operated macro,like BIT...

Cc: Sunil V L <[email protected]>
Cc: Leif Lindholm <[email protected]>
Cc: Michael D Kinney <[email protected]>
Cc: Daniel Schaefer <[email protected]>
Cc: Ray Ni <[email protected]>
Cc: Ran Wang <[email protected]>

Signed-off-by: Yang Wang <[email protected]>
Copy link
Contributor

@vlsunil vlsunil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than two minor comments, LGTM.

Platform/RISC-V/PlatformPkg/RiscVPlatformPkg.dec Outdated Show resolved Hide resolved
Silicon/Bosc/NanHuPkg/NanHuDevPkg.dec Outdated Show resolved Hide resolved
Yang Wang added 4 commits October 8, 2024 10:40
Pcihostbridgelib uses the general PCD variable.
Like PcdPciBusMin PcdPciBusMax ...

Cc: Sunil V L <[email protected]>
Cc: Leif Lindholm <[email protected]>
Cc: Michael D Kinney <[email protected]>
Cc: Daniel Schaefer <[email protected]>
Cc: Ray Ni <[email protected]>
Cc: Ran Wang <[email protected]>

Signed-off-by: Yang Wang <[email protected]>
The PCI Segment Library for Bosc NanHuDev platform.

Reviewed-by: Evan Chai <[email protected]>
Reviewed-by: Ran Wang <[email protected]>
Reviewed-by: Jian Zhang <[email protected]>
Cc: Sunil V L <[email protected]>
Cc: Leif Lindholm <[email protected]>
Cc: Michael D Kinney <[email protected]>
Cc: Daniel Schaefer <[email protected]>
Cc: Ray Ni <[email protected]>

Signed-off-by: Yang Wang <[email protected]>
Reviewed-by: Evan Chai <[email protected]>
Reviewed-by: Ran Wang <[email protected]>
Reviewed-by: Jian Zhang <[email protected]>
Cc: Sunil V L <[email protected]>
Cc: Leif Lindholm <[email protected]>
Cc: Michael D Kinney <[email protected]>
Cc: Daniel Schaefer <[email protected]>
Cc: Ray Ni <[email protected]>

Signed-off-by: Yang Wang <[email protected]>
Cc: Leif Lindholm <[email protected]>
Cc: Michael D Kinney <[email protected]>
Cc: Sunil V L <[email protected]>
Cc: Daniel Schaefer <[email protected]>

Signed-off-by: Yang Wang <[email protected]>
@vlsunil vlsunil merged commit 553b4c2 into tianocore:master Oct 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants