Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Platform/RISC-V: Add PCD variables related to PCI #212

Closed
wants to merge 2 commits into from

Conversation

wangy566
Copy link
Contributor

Pcihostbridgelib uses the general PCD variable.
Like PcdPciBusMin PcdPciBusMax ...

These PCDs made part of generic RISC-V package itself , so that they don't need to be added for every platform in the future.

Reviewed-by: Sunil V L <[email protected]>
Cc: Leif Lindholm <[email protected]>
Cc: Michael D Kinney <[email protected]>
Cc: Daniel Schaefer <[email protected]>
Cc: Ray Ni <[email protected]>

Yang Wang added 2 commits September 25, 2024 17:44
Add bit operated macro,like BIT...

Reviewed-by: Sunil V L <[email protected]>
Cc: Leif Lindholm <[email protected]>
Cc: Michael D Kinney <[email protected]>
Cc: Daniel Schaefer <[email protected]>
Cc: Ray Ni <[email protected]>

Signed-off-by: Yang Wang <[email protected]>
Pcihostbridgelib uses the general PCD variable.
Like PcdPciBusMin PcdPciBusMax ...

Reviewed-by: Sunil V L <[email protected]>
Cc: Leif Lindholm <[email protected]>
Cc: Michael D Kinney <[email protected]>
Cc: Daniel Schaefer <[email protected]>
Cc: Ray Ni <[email protected]>

Signed-off-by: Yang Wang <[email protected]>
@hrw
Copy link
Contributor

hrw commented Sep 25, 2024

So #211 or #212 will add RISCV_BIT_OP_H stuff?

@wangy566
Copy link
Contributor Author

So #211 or #212 will add RISCV_BIT_OP_H stuff?

#211

@vlsunil
Copy link
Contributor

vlsunil commented Sep 25, 2024

@wangy566 : This is not correct. Both #211 and #212 have same commit to add the bit operation macro which is the reason for @hrw to ask that question. Actually please update the #200 itself with more commits to address comments instead of raising new PRs. You can force push latest changes to same branch which will reflect in the PR.

Also, I have not yet reviewed the changes. So, please don't add Reviewed-by tag. These tags are not necessary with github PR based review process. Only Signed-off tag is mandatory.

@wangy566 wangy566 closed this Sep 26, 2024
@wangy566
Copy link
Contributor Author

@wangy566 : This is not correct. Both #211 and #212 have same commit to add the bit operation macro which is the reason for @hrw to ask that question. Actually please update the #200 itself with more commits to address comments instead of raising new PRs. You can force push latest changes to same branch which will reflect in the PR.

Also, I have not yet reviewed the changes. So, please don't add Reviewed-by tag. These tags are not necessary with github PR based review process. Only Signed-off tag is mandatory.

okay,Thank you for reminding me. I will correct it again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants