Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make Acker require Send+Sync, re-export redis connection manager #16

Merged
merged 1 commit into from
Aug 15, 2023

Commits on Aug 15, 2023

  1. make Acker require Send+Sync, re-export redis connection manager

    While updating bridge to use omniqueue, the usages already in place
    work, mostly as-is, with these two changes.
    
    WRT the redis re-export, rust was not able to infer to generic type for
    a Producer or Consumer and required that I specify the type for `R`.
    Rather than adding a dep on bb8 in bridge, it would be nicer to just
    have it re-exported.
    
    WRT `Acker`, bridge expected to run a consumer loop then hand each
    `Delivery` off to an async "handler" function. This failed to compile
    as-is citing the lack of `Send+Sync`. Making `Acker` a supertrait of
    `Send+Sync` was trivial since all the existing implementations were
    naturally `Send+Sync`, so this is probably not controversial.
    svix-onelson committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    ffd0d6a View commit details
    Browse the repository at this point in the history