make Acker require Send+Sync, re-export redis connection manager
#16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svix-onelson
force-pushed
the
onelson/bridge-fitting
branch
from
8ccc6b3
to
1e689c7
Compare
svix-onelson
changed the title
Acker require Send+Sync, re-export redis connection manager
While updating bridge to use omniqueue, the usages already in place work, mostly as-is, with these two changes. WRT the redis re-export, rust was not able to infer to generic type for a Producer or Consumer and required that I specify the type for `R`. Rather than adding a dep on bb8 in bridge, it would be nicer to just have it re-exported. WRT `Acker`, bridge expected to run a consumer loop then hand each `Delivery` off to an async "handler" function. This failed to compile as-is citing the lack of `Send+Sync`. Making `Acker` a supertrait of `Send+Sync` was trivial since all the existing implementations were naturally `Send+Sync`, so this is probably not controversial.
svix-onelson
force-pushed
the
onelson/bridge-fitting
branch
from
1e689c7
to
ffd0d6a
Compare
svix-aaron1011
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While updating bridge to use omniqueue, the usages already in place
work, mostly as-is, with these two changes.
WRT the redis re-export, rust was not able to infer to generic type for
a Producer or Consumer and required that I specify the type for
R.Rather than adding a dep on bb8 in bridge, it would be nicer to just
have it re-exported.
WRT
Acker, bridge expected to run a consumer loop then hand eachDeliveryoff to an async "handler" function. This failed to compileas-is citing the lack of
Send+Sync. MakingAckera supertrait ofSend+Syncwas trivial since all the existing implementations werenaturally
Send+Sync, so this is probably not controversial.