Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize keter #195

Open
wants to merge 39 commits into
base: master
Choose a base branch
from
Open

Modernize keter #195

wants to merge 39 commits into from

Conversation

tolysz
Copy link
Contributor

@tolysz tolysz commented Feb 19, 2019

Lots of changes. Mostly small additions, but also code move for ssl part.

  • Builds with process 1.6
  • add dependency for tls-session-manager, and it's support
  • add support for ssl certs for redirects, static-files, reverse proxies
  • fix http2 on reverse proxies
  • make it compile with ghc-8.6.3 / lts-13.8

resolver: lts-13.8
resolver: lts-12.8
resolver: lts-11.8
resolver: lts-10.8
@tolysz
Copy link
Contributor Author

tolysz commented Mar 12, 2019

saying:

fix http2 on reverse proxies

was a bit premature ;) i.e. there is a bit more configuration required. We use http client and server.
And there is a browser which request some HTTP version... currently it works only for some paths.

@idcm
Copy link

idcm commented Mar 19, 2019

when build this version, there are many warning. There are only one error.
error:
• The constructor ‘FSN.Removed’ should have 3 arguments, but has been given 2
• In the pattern: FSN.Removed fp _
when I replace IGNORE by _, it compile.

@tolysz
Copy link
Contributor Author

tolysz commented Mar 19, 2019

@idcm which version of fsnotify or resolver do you have?

@idcm
Copy link

idcm commented Mar 19, 2019

@idcm which version of fsnotify or resolver do you have?

lts-13.13 and fsnotify 0.3.0.1
also changes
http-reverse-proxy 0.6.0
yaml 0.11.0.0
in keter.cabal

@idcm
Copy link

idcm commented Mar 24, 2019

@tolysz
you can fix the many warning ? ;)

@tolysz
Copy link
Contributor Author

tolysz commented Mar 24, 2019

The fixes deserve a separate commit, and a decision what is the minimum LTS.

@benjamingoldstein
Copy link
Contributor

This looks really good. What is holding this back from being made into the main source code?
Alternatively, how can I get this and run it?

@mmzx
Copy link
Collaborator

mmzx commented Sep 29, 2020

I had been: with the addition of #203 , if you look back the history of this very PR.

@tolysz
Copy link
Contributor Author

tolysz commented Sep 29, 2020

At this point I would need to cleanup/rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants