Add per bundle certificates for static files and redirects. #163
Conversation
| @@ -255,6 +257,7 @@ instance ParseYamlFile StaticFilesConfig where | |||
| <*> o .:? "directory-listing" .!= False | |||
| <*> o .:? "middleware" .!= [] | |||
| <*> o .:? "connection-time-bound" | |||
| <*> o .:? "ssl" .!= SSLFalse | |||
There was a problem hiding this comment.
It would be nice to have an example, even if it's "commented out"
There was a problem hiding this comment.
updated, but it is exactly the same syntax as for webapp
| -> IO a | ||
| withActions asc bconfig f = | ||
| loop (V.toList $ bconfigStanzas bconfig) [] [] Map.empty | ||
| where | ||
| -- todo: add loading from relative location |
There was a problem hiding this comment.
what's missing to support this now?
There was a problem hiding this comment.
This is a pointer for others, I am happy with an absolute path.
I.e. I am using letsencrypt via https://github.com/lukas2511/dehydrated to generate certs in a fixed location in the filesystem (and I have to regenerate them every couple of months), then have my bundles to point to that absolute folders.
|
I like this. It would be nice to have examples, if possible. I left a review but approved these changes.
Otherwise, looks great. |
|
Redirects :) Previously, the redirect, if connected via The last stantza left is the |
|
I added the |
|
@tolysz I've reviewed this one a few times and the code looks good. I really like the feature. The one thing I would still add is documentation about the absolute path considering the primary keter config can take a relative path. @snoyberg you might still want to take a quick look at this one when you have time. I haven't worked much on Keter core so the code is very unfamiliar. |
Ubuntu uses systemd for version 15.04 and greater as default now.
* add dependency for `tls-session-manager` * bump resolver
|
All the changes are merged into: #195 |
Allow extending
static files and redirect stansaz with a custom certificate.
Redirects were not obvious, but they would fail on https