Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log exception instead of message #1522

Closed
wants to merge 2 commits into from
Closed

Log exception instead of message #1522

wants to merge 2 commits into from

Conversation

jdcaperon
Copy link

@jdcaperon jdcaperon commented Oct 3, 2023 •
edited
Loading

Currently when an error is encountered its entirely possible for an exception to have been thrown with no message. This means we end up with logs that look like:

Exception encountered during file upload:

This makes the log line largely useless for debugging purposes.

Fixes #1530

@jdcaperon
Log exception instead of message
28065af 
Currently when an error is encountered its entirely possible for an exception to have been thrown with no message. This means we end up with logs that look like:

`Exception encountered during file upload: `

This makes the log line largely useless for debugging purposes.
@jdcaperon jdcaperon requested a review from a team as a code owner October 3, 2023 23:06
@github-actions
Copy link

github-actions bot commented Oct 3, 2023

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

You can retrigger this bot by commenting recheck in this Pull Request

@jdcaperon
Copy link
Author

Canva has signed a corporate CLA with Snowflake which covers this contribution.

@jdcaperon jdcaperon mentioned this pull request Oct 12, 2023
Closed
sfc-gh-igarish
sfc-gh-igarish approved these changes Oct 13, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-igarish sfc-gh-igarish mentioned this pull request Oct 13, 2023
Merged
8 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2023
@sfc-gh-japatel
Copy link
Collaborator

Closed because #1531 is merged

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-igarish sfc-gh-igarish sfc-gh-igarish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SNOW-939849: Improve exception logging information
3 participants
@jdcaperon @sfc-gh-japatel @sfc-gh-igarish