Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-928802 Fix logger error where the message/stack trace is not printed #1531

Merged
merged 1 commit into from
Oct 13, 2023
Merged

SNOW-928802 Fix logger error where the message/stack trace is not printed #1531

merged 1 commit into from
Oct 13, 2023

Conversation

sfc-gh-japatel
Copy link
Collaborator

Overview

SNOW-928802
While debugging, I saw this error message but there is no stack trace so makes it hard to debug.

External contributors - please answer these questions before submitting a pull request. Thanks!

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

Pre-review checklist

  • This change has passed precommit
  • I have reviewed code coverage report for my PR in (Sonarqube)

@sfc-gh-japatel sfc-gh-japatel requested a review from a team as a code owner October 13, 2023 00:27
sfc-gh-igarish
sfc-gh-igarish approved these changes Oct 13, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is same as this PR: #1522. Please close it, once you merge this one.

@sfc-gh-japatel sfc-gh-japatel merged commit 0a8680c into master Oct 13, 2023
14 of 16 checks passed
@sfc-gh-japatel sfc-gh-japatel deleted the japatel-SNOW-928802-fix-logger-error branch October 13, 2023 03:59
@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-igarish sfc-gh-igarish sfc-gh-igarish approved these changes

@sfc-gh-tjones sfc-gh-tjones Awaiting requested review from sfc-gh-tjones

@sfc-gh-tzhang sfc-gh-tzhang Awaiting requested review from sfc-gh-tzhang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-japatel @sfc-gh-igarish