-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix#445 #455
base: main
Are you sure you want to change the base?
Fix#445 #455
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you try to increase test coverage to cover more of these options? Codecov reports some of these lines as unchecked currently.
Co-authored-by: Martin Fleischmann <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #455 +/- ##
========================================
+ Coverage 78.7% 78.8% +0.1%
========================================
Files 122 122
Lines 12884 12898 +14
========================================
+ Hits 10142 10163 +21
+ Misses 2742 2735 -7
|
What does this need to merge? |
We should test the use case from #445 this is supposed to fix. It is not being covered by current tests. |
Hello! Please make sure to check all these boxes before submitting a Pull Request
(PR). Once you have checked the boxes, feel free to remove all text except the
justification in point 5.
pytest
on your changes. Continuous integration will be run on all PRs with GitHub Actions, but it is good practice to test changes locally prior to a making a PR.pysal/master
branch.docstrings and
unittests?
reviewer and added relevant labels
DataArray
objects read throughrioxarray
#445