-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kmod scripts new branch #463
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. I like it much more with just a few clean scripts / modules and one main entrypoint.
Plenty of little things here and there, most of it surface level. As usual I'm not too manic about it and they should be considered suggestions more than demands, obviously.
There are a few questions in the lot that I'd like to see answered as I might have misunderstood in a few places.
I expect this can easily be merged today if you get on it :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only requesting changes to fix the documentation build, otherwise all good!
Code Climate has analyzed commit a1878a0 and detected 9 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 91.4% (50% is the threshold). This pull request will bring the total coverage in the repository to 85.9% (0.0% change). View more on Code Climate. |
Scripts are separate in omc3 for now, but could be added into a separate directory if needed.
TODO (jdilly):