Unit Testing Helper #136
Merged
Unit Testing Helper #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsoubelet
added
Type: Feature
|
I've added a little tweak to the coverage workflow so it prints out coverage to the console on CI runs, after running tests. Some coverage is dropped because the contents of |
jgray-19
reviewed
Nov 14, 2024
JoschD
requested changes
Nov 14, 2024
|
I have tried to make very explicit the behaviour changes from passing |
JoschD
approved these changes
Nov 14, 2024
jgray-19
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #135 (pending) I introduced the
assert_tfs_frame_equalfunction in theconftest.pyfile, which is quite convenient.In pylhc/omc3#463 a similar version was introduced in
omc3, with tests, and we figured it would make sense to provide it as a public API from thetfspackage directly.In this PR I introduce a
tfs.testingmodule, with theassert_tfs_frame_equalfunction there. Tests have been copied over from those implemented by @JoschD in pylhc/omc3#463.Version is bumped to
3.9.0, changelog updated. This can safely be merged and released, and I'll take care of merging back into #135 to use the new functionality there.