Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relationship field: Fix return data when value exists + Allow -1 as limit #7143

Merged
merged 3 commits into from
Sep 4, 2023
Merged

Relationship field: Fix return data when value exists + Allow -1 as limit #7143

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
500134a
Allow -1 as limit
JoryHogeveen Aug 30, 2023
8c65fb5
Merge/append the current value(s) to the list of results.
JoryHogeveen Aug 30, 2023
a0f358b
Merge branch 'release/3.0' into feature/7111-relations
sc0ttkclark Sep 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions classes/fields/pick.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2743,7 +2743,7 @@ public function get_object_data( $object_params = null ) {

$params['limit'] = apply_filters( 'pods_form_ui_field_pick_autocomplete_limit', $limit, $name, $value, $options, $pod, $id, $object_params );

if ( is_array( $value ) && $params['limit'] < count( $value ) ) {
if ( -1 !== (int) $params['limit'] && is_array( $value ) && $params['limit'] < count( $value ) ) {
$params['limit'] = count( $value );
}

Expand Down Expand Up @@ -2894,7 +2894,7 @@ public function get_object_data( $object_params = null ) {
$params['where'] .= "`t`.`{$search_data->field_id}` IN ( {$ids} )";

try {
$results = $search_data->select( $params );
$results = array_merge( $results, $search_data->select( $params ) );
} catch ( Exception $exception ) {
if ( pods_is_debug_display() ) {
pods_error_exception( $exception );
Expand Down
Loading