Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relationship field: Fix return data when value exists + Allow -1 as limit #7143

Merged
merged 3 commits into from
Sep 4, 2023

Conversation

JoryHogeveen
Copy link
Member

@JoryHogeveen JoryHogeveen commented Aug 30, 2023

Description

Allow -1 (unlimited) as filtered value for the relationship limit

Related GitHub issue(s)

Fixes: #7111

Changelog text for these changes

PR checklist

@what-the-diff
Copy link

what-the-diff bot commented Aug 30, 2023

PR Summary

  • Add Condition to Limit Check
    To ensure smooth operation, we've added a safeguard in the pick.php file. Now it verifies that the 'limit' value isn't equal to -1 before comparing it with the size of a certain set of data. This helps to reduce the likelihood of any errors during this process.

  • Enhancing Search Select Results
    We've made improvements to how we handle the results of a search selection in the same pick.php file. The returned search results are now merged into the existing array of results, providing a more comprehensive overview when a search is performed.

@JoryHogeveen JoryHogeveen changed the title Allow -1 as limit Relationship field: Fix return data when value exists + Allow -1 as limit Aug 30, 2023
@JoryHogeveen JoryHogeveen self-assigned this Aug 30, 2023
@sc0ttkclark sc0ttkclark changed the base branch from main to release/3.0 September 4, 2023 04:55
@sc0ttkclark sc0ttkclark added this to the Pods 3.0 milestone Sep 4, 2023
@sc0ttkclark sc0ttkclark merged commit 37cdd4b into release/3.0 Sep 4, 2023
7 checks passed
@sc0ttkclark sc0ttkclark deleted the feature/7111-relations branch September 4, 2023 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Keywords: Regression Status: PR > Pending Code Review PR is pending code review by core developers Status: PR > QA pending QA needs to be done Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi-select autocomplete does not show any options when there are previous selections
2 participants