Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] Add upgrade lock file and healthcheck to the container #60

Closed
wants to merge 4 commits into from

Conversation

wuast94
Copy link
Member

@wuast94 wuast94 commented Oct 10, 2024

Should fix #59

dont have time to test it but should work.

@wuast94 wuast94 marked this pull request as draft October 10, 2024 20:54
@justinclift
Copy link
Member

Awesome! I'll take a look at this over the next few days.

CI seems to be failing atm, but it probably won't be hard to get things working the way we want. 😄

@justinclift
Copy link
Member

As a quick eyeball of this (proper review will come later), I wonder if the CI problem is from the execute bit not being set on the new script?

new file mode 100644

@justinclift
Copy link
Member

justinclift commented Oct 11, 2024

Hmmm, this seems like mismatching file names too:

COPY pgautoupgrade-postupgrade.sh healthcheck.sh /usr/local/bin/

vs:

HEALTHCHECK CMD /usr/local/bin/healthcheck-script.sh

Will probably need to build a container using this PR and check properly. Prob not tonight though. 😉

@wuast94
Copy link
Member Author

wuast94 commented Oct 11, 2024

good catch, i changed the script name and missed this

@justinclift
Copy link
Member

Interestingly, it looks like the CI checks aren't functional when the PR is created in a different repo. I'll re-create this PR with the commits in branch of our repo, so we can see the actual CI check results. 😄

@justinclift
Copy link
Member

Created #63 so we can see how CI goes. Interestingly, it seems the CI for #63 is now showing up here too. Maybe it's due to the identical commit hashes?

@justinclift
Copy link
Member

Actually, lets close this PR and continue the development in #63. If changes do need to be made, then we'll need to do them in that PR anyway. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Healthcheck could break update
2 participants