-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Draft] Add upgrade lock file and healthcheck to the container #60
Conversation
Awesome! I'll take a look at this over the next few days. CI seems to be failing atm, but it probably won't be hard to get things working the way we want. 😄 |
As a quick eyeball of this (proper review will come later), I wonder if the CI problem is from the execute bit not being set on the new script?
|
Hmmm, this seems like mismatching file names too:
vs:
Will probably need to build a container using this PR and check properly. Prob not tonight though. 😉 |
good catch, i changed the script name and missed this |
Interestingly, it looks like the CI checks aren't functional when the PR is created in a different repo. I'll re-create this PR with the commits in branch of our repo, so we can see the actual CI check results. 😄 |
Actually, lets close this PR and continue the development in #63. If changes do need to be made, then we'll need to do them in that PR anyway. 😄 |
Should fix #59
dont have time to test it but should work.