Healthcheck could break update

[wuast94]

i run this image in a swarm cluster that checks for health and if the container is unhealthy it restarts the container and try to get it running. this will happn in the upgrade process which dont work.

i used

healthcheck:
    test: [CMD-SHELL, "pg_isready -d $${POSTGRES_DB} -U $${POSTGRES_USER}"]
    start_period: 20s
    interval: 30s
    retries: 5
    timeout: 5s

i think nothing we can do about directly (maybee providing a script that does this healthcheck but will also exit code 0 when an update is running?) but more a think we should mention?

[justinclift]

Oh, yeah that's a good point.

That sounds like a good idea too. Having some kind of health check script which takes into account that a potential upgrade might be in progress.

We could probably use some kind of placeholder file (ie touch $PGDATA/.pgautoupgrade_occuring or similar) in the docker entrypoint script as a way for other processes in the container to check if an upgrade is in progress.

Want to throw together a PR with a script to get this all working ok? 😄

[wuast94]

i can look into it the next days :)

[justinclift]

As a data point, the PR for this is now #63 rather than #60. 😄

[justinclift]

Merged that PR. Lets see how it goes in actual use. 😄

[wuast94]

had an upgrade from 14 to 17 on a friends db without problems. also my dbs are running fine. lets see what the next major release will do :) dont have any old db to test atm

[justinclift]

Yeah. It passes all of the automated testing too, so the main upgrade functionality is ok at a minimum. 😉

[andyundso]

if I have one input: I could imagine that a couple of folks keep their standard healthcheck with pg_ready when swapping out their PG container for ours. maybe we can add a small section in the README that clarifies that we bake in a healthcheck now.

[justinclift]

That's a decent idea. Anyone feel like writing it? 😄

[wuast94]

That's a decent idea. Anyone feel like writing it? 😄

i think another one for me :P

[justinclift]

A wild volunteer appears! 😁

[wuast94]

done