[Challenge] Add Nuzlocke-related challenges #4311

DayKev · 2024-09-18T10:43:18Z

Todo:

Change method of "one catch per biome" restriction
Prevent fusions with fainted Pokémon in hardcore challenge
- Would also affect splicing in other challenges, needs balance team discussion
Restrict MEs that call PartyHealPhase from appearing during no autoheal challenge?

What are the changes the user will see?

Adds 3 new challenges:

"No Free Heal": Disables the automatic healing that occurs after every 10th wave, replacing it with a normal shop phase
"Hardcore": Fainted Pokémon can't be revived
"Limited Catch": Only the first wild Pokémon encounter
of every biome can be added to your current party (ie: from waves 1, 11, 21, ...)
- Takes into account if the X1 wave was a ME, allowing you to catch the Pokémon on wave X2 instead

Why am I making these changes?

Nuzlocke mode is a popular request/on the roadmap.

What are the changes from a developer perspective?

6 new ChallengeTypes were added:

NO_HEAL_PHASE
Checks if the heal phase after every 10th wave should be activated. See src/phases/party-heal-phase.ts
SHOP_ITEM_BLACKLIST
Filters the shop for specific items. See src/modifier/modifier-type.ts and src/ui/modifier-select-ui-handler.ts
RANDOM_ITEM_BLACKLIST
Filters the random item selection for specific items. See src/modifier/modifier-type.ts
ADD_POKEMON_TO_PARTY
Checks if the current caught Pokémon can be added to the party. See src/phases/attempt-capture-phase.ts
MOVE_BLACKLIST
Checks if move the user wants to use is illegal for this challenge. See src/phases/command-phase.ts
PREVENT_REVIVE
Checks if Pokémon can be revived. See src/phases/party-heal-phase.ts

Screenshots/Videos

Starter filter with "No Legends" challenge active

Shop with "Hardcore" challenge active

Lack of auto-heal with "No Free Heal" challenge active

no.auto.heal.challenge.mp4

Caught Pokémon not going to party with "Limited Catch" challenge active

pokemon.doesn.t.go.to.party.mp4

How to test the changes?

Start a new challenge run with one or more of the challenges active.

Checklist

I'm using beta as my base branch
There is no overlap with another PR?
- Updated version of [Enhancement][Challenge] Nuzlocke challenge #2421
The PR is self-contained and cannot be split into smaller PRs?
- The individual challenges are related to a common overarching challenge
Have I provided a clear explanation of the changes?
Have I considered writing automated tests for the issue?
If I have text, did I make it translatable and add a key in the English locale file(s)?
Have I tested the changes (manually)?
- Are all unit tests still passing? (npm run test)
~~[ ] Are the changes visual?~~
- Have I provided screenshots/videos of the changes?

DayKev · 2024-09-19T13:40:11Z

I see it picks 3 random people to request for review now lmao.

Anyway, more or less ready (still need to figure out some tests). Could use some opinions on the challenge names/descriptions, I didn't spend long on them.

frutescens

Could you edit challengeParser() in run-info-ui-handler to process these new challenges?

Adri1 · 2024-09-20T14:13:37Z

Question: "Hardcore" mode also prevent the Pokémon to be heald every 10 waves, or it only applies to reviving items?

DayKev · 2024-09-21T06:26:52Z

Question: "Hardcore" mode also prevent the Pokémon to be heald every 10 waves, or it only applies to reviving items?

It only prevents reviving, non-fainted Pokémon will still be healed if only Hardcore is active.

done

src/test/challenge/no_legends.test.ts

src/test/challenge/no_auto_heal.test.ts

src/test/challenge/hardcore.test.ts

src/data/challenge.ts

src/modifier/modifier-type.ts

src/data/challenge.ts

src/locales/en/challenges.json

SangaraSorama

Approval for the locales folder.

src/modifier/modifier-type.ts

src/data/challenge.ts

PigeonBar · 2024-10-17T13:36:13Z

src/data/challenge.ts

+  }
+
+  override applyAddPokemonToParty(pokemon: EnemyPokemon, waveIndex: number, canAddToParty: BooleanHolder): boolean {
+    if (!(waveIndex % 10 === 1) && !(pokemon.scene.lastMysteryEncounter && (waveIndex % 10 === 2))) {


lastMysteryEncounter gets cleared upon reload (it's only used for clearing the last wave's ME visuals), so the player would no longer be able to add a wild Pokemon to the party if they reload on wave X2 after an ME.

There's also an edge case of ME on wave X1 and then trainer battle on wave X2, which would not allow the player to add any Pokemon from that biome.

Would it be possible for the session save data to keep track of a mostRecentWildEncounter instead (it would probably also require changes to the backend DB)? If not, then we could use mysteryEncounterSaveData.encounteredEvents to search for wave X1 ME's instead.

Hm, I'll look into it and see what can be done.

Adding to this, some MEs let you fight and catch a mon (or even several mons, like the Safari Zone) so it probably needs to be considered even with PigeonBar's suggestion
Some MEs also allow to get a mon without needing to catch it like the Oricorio one or the Pokemon Salesman, should that be allowed for this challenge if not on wave X1?

PigeonBar · 2024-10-17T14:02:32Z

src/phases/party-heal-phase.ts

+    if (!isHealPhaseActive.value) {
+      this.scene.unshiftPhase(new SelectModifierPhase(this.scene));
+      return this.end();
+    }


Some ME's also use PartyHealPhase now. What is the intended behaviour here?

20241017.ME.Party.Heal.mp4

Uh, hm... I hadn't considered MEs (well, they didn't even exist when the challenge was first added). Will probably have to consult with damo on this.

PigeonBar · 2024-10-17T14:12:12Z

Run history entries could start to get crowded with all the available challenge options:

PigeonBar · 2024-10-17T14:33:17Z

In the Hardcore challenge, should the player be allowed to splice a fainted Pokemon with an alive Pokemon, which would sort of allow the fainted Pokemon to participate again?

PigeonBar · 2024-10-17T15:04:36Z

The Hardcore challenge still allows rewards to contain hardcoded revival items from certain ME's (e.g., A Trainer's Test):

PigeonBar · 2024-10-17T15:35:22Z

The Hardcore challenge allows Revival Blessing to be used indirectly, such as from Sleep Talk:

20241017.Sleep.Talk.Revival.mp4

RevivalBlessingAttr distinguishes between reviving player Pokemon and reviving enemy Pokemon, so we could probably apply the challenge and have the move fail there instead.

Adri1 · 2024-10-17T18:08:21Z

Would it be possible to add "short_name" keys to be used in the Run History?
Like it's already the case for "Inverse Battle" challenge:

In order to limit this kind of scenario, when possible:

DayKev · 2024-10-17T19:56:40Z

Would it be possible to add "short_name" keys to be used in the Run History?

Sure. I'm not sure what the best short names to use are though.

In the Hardcore challenge, should the player be allowed to splice a fainted Pokemon with an alive Pokemon, which would sort of allow the fainted Pokemon to participate again?

Probably not. Ugh, fusions...

MokaStitcher

(not done with reviewing at all, just submitting to share the comments i have so far)

src/data/challenge.ts

MokaStitcher · 2024-10-17T20:02:55Z

src/data/challenge.ts

+  }
+
+  override applyAddPokemonToParty(pokemon: EnemyPokemon, waveIndex: number, canAddToParty: BooleanHolder): boolean {
+    if (!(waveIndex % 10 === 1) && !(pokemon.scene.lastMysteryEncounter && (waveIndex % 10 === 2))) {


Adding to this, some MEs let you fight and catch a mon (or even several mons, like the Safari Zone) so it probably needs to be considered even with PigeonBar's suggestion
Some MEs also allow to get a mon without needing to catch it like the Oricorio one or the Pokemon Salesman, should that be allowed for this challenge if not on wave X1?

Adri1 · 2024-10-17T22:03:26Z

Sure. I'm not sure what the best short names to use are though.

Might not always apply for English, but might apply for some languages

damocleas · 2024-10-18T01:44:39Z

Would it be possible to add "short_name" keys to be used in the Run History? Like it's already the case for "Inverse Battle" challenge:

In order to limit this kind of scenario, when possible:

Would it not be better to just have this menu show the achievement icons with a hover over for the name? Different PR issue likely.

damocleas · 2024-10-18T01:46:41Z

Or, well, on the above, a small icon to indicate each challenge type will likely be needed in the future as they wouldn't all have achievements associated likely. Unsure how to shorten them though.

PigeonBar · 2024-10-20T03:00:16Z

It turns out that after beating Wave X0, PartyHealPhase normally runs after the global RNG gets set for Wave X1. This means that in the No Free Heal challenge, replacing PartyHealPhase with SelectModifierPhase can cause item generation (especially rerolls) to interfere with RNG for generating the wild Pokemon in Wave X1.

To avoid the problem, we could instead have PartyHealPhase simply do nothing if No Free Heal is active, and have SelectModifierPhase activate normally from VictoryPhase (which occurs before RNG gets set for Wave X1) as if it were a non-X0 wave.

- "No Free Heal": Disables the automatic healing that occurs after every 10th wave, replacing it with a normal shop phase - "Hardcore": Fainted Pokémon can't be revived - "Limited Catch": Only the first wild Pokémon encounter of every biome can be added to your current party

Blitz425 · 2024-10-25T16:08:19Z

Is it possible to reuse the code from Sam's original nuzlocke mode that makes cries longer when a Pokemon faints in permadeath? It's such a small thing but it makes death's feel more impactful

DayKev · 2024-10-26T06:04:41Z

Is it possible to reuse the code from Sam's original nuzlocke mode that makes cries longer when a Pokemon faints in permadeath? It's such a small thing but it makes death's feel more impactful

What exactly do you mean by longer? Like, the cry should be slowed down so that it takes a longer time to complete? By how much; and what should be done about pitch shifting, if anything?

DayKev added Enhancement New feature or request Challenges Challenge mode/s related labels Sep 18, 2024

DayKev mentioned this pull request Sep 18, 2024

[Enhancement][Challenge] Nuzlocke challenge #2421

Closed

7 tasks

DayKev force-pushed the nuzlocke-update branch from 8172200 to d381734 Compare September 19, 2024 10:18

DayKev marked this pull request as ready for review September 19, 2024 13:38

DayKev requested review from a team as code owners September 19, 2024 13:38

DayKev requested review from chaosgrimmon, CodeTappert and KimJeongSun September 19, 2024 13:38

frutescens previously requested changes Sep 20, 2024

View reviewed changes

KimJeongSun reviewed Sep 21, 2024

View reviewed changes

src/test/challenge/no_legends.test.ts Outdated Show resolved Hide resolved

KimJeongSun reviewed Sep 21, 2024

View reviewed changes

src/test/challenge/no_auto_heal.test.ts Outdated Show resolved Hide resolved

KimJeongSun reviewed Sep 21, 2024

View reviewed changes

src/test/challenge/hardcore.test.ts Outdated Show resolved Hide resolved

Xavion3 suggested changes Sep 30, 2024

View reviewed changes

src/data/challenge.ts Show resolved Hide resolved

src/data/challenge.ts Outdated Show resolved Hide resolved

src/data/challenge.ts Outdated Show resolved Hide resolved

src/data/challenge.ts Outdated Show resolved Hide resolved

Fontbane reviewed Sep 30, 2024

View reviewed changes

src/modifier/modifier-type.ts Outdated Show resolved Hide resolved

src/data/challenge.ts Outdated Show resolved Hide resolved

Adri1 reviewed Sep 30, 2024

View reviewed changes

src/locales/en/challenges.json Outdated Show resolved Hide resolved

SangaraSorama previously approved these changes Sep 30, 2024

View reviewed changes

DayKev marked this pull request as draft October 1, 2024 00:42

DayKev dismissed SangaraSorama’s stale review via c965fa5 October 2, 2024 10:55

DayKev commented Oct 2, 2024

View reviewed changes

src/modifier/modifier-type.ts Outdated Show resolved Hide resolved

DayKev mentioned this pull request Oct 3, 2024

Nuzlocke challenges EN keys pagefaultgames/pokerogue-locales#10

Merged

Fontbane reviewed Oct 10, 2024

View reviewed changes

src/data/challenge.ts Outdated Show resolved Hide resolved

f-fsantos added Game Balance Changes focused on game balance Balance Team Specifically a balance team change labels Oct 13, 2024

DayKev force-pushed the nuzlocke-update branch from 5fa30b8 to f600dfd Compare October 13, 2024 21:20

DayKev requested review from damocleas and KimJeongSun October 15, 2024 23:54

damocleas previously approved these changes Oct 16, 2024

View reviewed changes

DayKev dismissed damocleas’s stale review via 589cd4b October 16, 2024 02:23

DayKev requested review from damocleas and Fontbane October 16, 2024 02:25

damocleas previously approved these changes Oct 16, 2024

View reviewed changes

PigeonBar reviewed Oct 17, 2024

View reviewed changes

MokaStitcher reviewed Oct 17, 2024

View reviewed changes

DayKev dismissed damocleas’s stale review via 782dd02 October 18, 2024 00:30

DayKev marked this pull request as draft October 20, 2024 08:36

DayKev force-pushed the nuzlocke-update branch 3 times, most recently from d885134 to 9172303 Compare October 24, 2024 08:55

Prevent fainted pokemon from being spliced in hardcore

4de5572

DayKev force-pushed the nuzlocke-update branch from 9172303 to 4de5572 Compare October 24, 2024 08:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Challenge] Add Nuzlocke-related challenges #4311

[Challenge] Add Nuzlocke-related challenges #4311

DayKev commented Sep 18, 2024 •

edited

Loading

DayKev commented Sep 19, 2024

frutescens left a comment

Adri1 commented Sep 20, 2024

DayKev commented Sep 21, 2024

SangaraSorama left a comment

PigeonBar Oct 17, 2024

DayKev Oct 17, 2024

MokaStitcher Oct 17, 2024

PigeonBar Oct 17, 2024

DayKev Oct 17, 2024

PigeonBar commented Oct 17, 2024

PigeonBar commented Oct 17, 2024

PigeonBar commented Oct 17, 2024

PigeonBar commented Oct 17, 2024

Adri1 commented Oct 17, 2024 •

edited

Loading

DayKev commented Oct 17, 2024

MokaStitcher left a comment

MokaStitcher Oct 17, 2024

Adri1 commented Oct 17, 2024

damocleas commented Oct 18, 2024

damocleas commented Oct 18, 2024 •

edited

Loading

PigeonBar commented Oct 20, 2024

Blitz425 commented Oct 25, 2024

DayKev commented Oct 26, 2024

[Challenge] Add Nuzlocke-related challenges #4311

Are you sure you want to change the base?

[Challenge] Add Nuzlocke-related challenges #4311

Conversation

DayKev commented Sep 18, 2024 • edited Loading

What are the changes the user will see?

Why am I making these changes?

What are the changes from a developer perspective?

Screenshots/Videos

How to test the changes?

Checklist

DayKev commented Sep 19, 2024

frutescens left a comment

Choose a reason for hiding this comment

Adri1 commented Sep 20, 2024

DayKev commented Sep 21, 2024

SangaraSorama left a comment

Choose a reason for hiding this comment

PigeonBar Oct 17, 2024

Choose a reason for hiding this comment

DayKev Oct 17, 2024

Choose a reason for hiding this comment

MokaStitcher Oct 17, 2024

Choose a reason for hiding this comment

PigeonBar Oct 17, 2024

Choose a reason for hiding this comment

DayKev Oct 17, 2024

Choose a reason for hiding this comment

PigeonBar commented Oct 17, 2024

PigeonBar commented Oct 17, 2024

PigeonBar commented Oct 17, 2024

PigeonBar commented Oct 17, 2024

Adri1 commented Oct 17, 2024 • edited Loading

DayKev commented Oct 17, 2024

MokaStitcher left a comment

Choose a reason for hiding this comment

MokaStitcher Oct 17, 2024

Choose a reason for hiding this comment

Adri1 commented Oct 17, 2024

damocleas commented Oct 18, 2024

damocleas commented Oct 18, 2024 • edited Loading

PigeonBar commented Oct 20, 2024

Blitz425 commented Oct 25, 2024

DayKev commented Oct 26, 2024

DayKev commented Sep 18, 2024 •

edited

Loading

Adri1 commented Oct 17, 2024 •

edited

Loading

damocleas commented Oct 18, 2024 •

edited

Loading