[Enhancement][Challenge] Nuzlocke challenge #2421

sirzento · 2024-06-19T21:54:17Z

What are the changes?

This PR adds the challenge mod "Nuzlocke" to the game. As a result, various new challenge checks will be added that can also be used for other challenges in the future.

Why am I doing these changes?

I have seen some feature request for a nuzlocke challenge. Also, the old roadmap even had a nuzlocke mode as goal.

What did change?

The Nuzlocke challenge aswell as the achievement for it was added. I also changed the challenge UI and made the description field larger to be able to display more text.

5 new challengeType's where added to check for various rules in the nuzlocke challenge.
Those types are:

NO_HEAL_PHASE
Checks if the heal phase after every 10th round should be activated.
SHOP_ITEM_BLACKLIST
Filters the shop for specific items.
RANDOM_ITEM_BLACKLIST
Filters the random item selection for specific items.
ADD_POKEMON_TO_PARTY
Checks if the current catched pokemon can be added to the party.
MOVE_BLACKLIST
Checks if move the user wants to use is illegal for this challenge.

Screenshots/Videos

Nuzlocke Regular:

Nuzlocke Hardcore:

How to test the changes?

Set POKEBALL_OVERRIDE to have some masterballs and MOVESET_OVERRIDE to include Moves.REVIVAL_BLESSING.
You can also set OPP_LEVEL_OVERRIDE to 1.

Start a new challenge with Nuzlocke challenge enabled and check:

if you are healed after the 10th round
if you can buy revive
if you can role for a reviver seed
you can use revival blessing
if you can only add one pokemon every 10 floors to the party

Checklist

There is no overlap with another PR?
The PR is self-contained and cannot be split into smaller PRs?
Have I provided a clear explanation of the changes?
Have I tested the changes (manually)?
- Are all unit tests still passing? (npm run test)
Are the changes visual?
- Have I provided screenshots/videos of the changes?

feat: Add link to Discord in menu UI feat: Add Discord and Google login functionality Add container around discord and google icons refactor: Update environment variable names for Discord and Google client IDs feat: Add "Or use" translation for login options in multiple languages feat: Update menu UI translations for multiple languages Code review fixes refactor: Update Discord and Google client IDs in environment variables

Corrade · 2024-06-20T11:18:10Z

There's an existing Nuzlocke PR, but it was created before the addition of challenges.
#457

Maybe an opportunity for collaboration or superseding?

sirzento · 2024-06-20T11:28:14Z

There's an existing Nuzlocke PR, but it was created before the addition of challenges. #457

Maybe an opportunity for collaboration or superseding?

That's Sam and he left. I already looked into the code but I can't use anything since everything changes so much and there is also so much other stuff like custom nuzlocke trainer etc. I will ask to close that old PR.

And I am actually mostly done with rule logic because the challege system is pretty easy to use.

…lenge save game

Co-authored-by: Jannik Tappert <[email protected]>

…N_TO_PARTY.

… from regular challenge.

this also reduces output noise in tests

… a bug that lets random forbidden items spawn.

hayuna · 2024-06-29T07:50:12Z

@sirzento What about this scenario?

Opponent has REVIVER_SEED
Player is using thief move

Player will take REVIVER_SEED from opponent. Should this be illegal in nuzlocke mode?

sirzento · 2024-06-29T09:14:54Z

@sirzento What about this scenario?

Opponent has REVIVER_SEED Player is using thief move

Player will take REVIVER_SEED from opponent. Should this be illegal in nuzlocke mode?

@hayuna Yeah I thought about it and just thought it will be alright because it's just so rare to get it like that. I could disable it somehow if that's wanted but I think it will be alright like that.

* Bug Fix * Update src/system/game-stats.ts Co-authored-by: flx-sta <[email protected]> * Fixing a test * Fixed import * Revert "Bug Fix" This reverts commit 8348449. --------- Co-authored-by: Frutescens <info@laptop> Co-authored-by: flx-sta <[email protected]>

…eams (pagefaultgames#3124)

…ames#3122) * Bug Fix * Update src/system/game-stats.ts Co-authored-by: flx-sta <[email protected]> * Fixing a test * Revert "Fixing a test" This reverts commit 1bdbe2d. * Test Re-Run --------- Co-authored-by: Frutescens <info@laptop> Co-authored-by: flx-sta <[email protected]>

…ch and double battles (pagefaultgames#2462) * Adjust how counter attacks target to account for uturn/voltswitch * Creates move flag for metal burst/comeuppance to redirect in some cases * Remove debug printing * Bit shifts the redirect counter flag * Removes extraneous class from prior testing * Remove vitest timestamp file that was accidentally added

Mystic ticket icons in the achievements just confuse players

…red in dex (pagefaultgames#2713) * Fix reins et al being available without unlocking second mon * Small fix * Parentheses for safety * Add documentation to new function

Co-authored-by: Frutescens <info@laptop>

…stats (pagefaultgames#3117) * Fixed OHKO moves being affected by accuracy and evasion battle stats * Added related tests for Fissure, unskipped related test for Hustle * Tweaked fissure accuracy and evasion tests to use spyOn() for getAccuracyMultiplier() as per feedback * Fixed accuracy test for Fissure

* [Fix][Sprite] Politoed Back Sprites Retrieved first version from history. Rearranged frames to make jump a little less floaty. Set same anim length for all variations. Json is identical for all variations. Spritesheet frame position is identical for all variations. Trimmed the frame of extra space Reduced file size of spritesheets and JSON due to less unique frames needed. * [Fix][Sprite] Politoed Back Sprites - Reformatted JSON to texturepacker standard Reformatted json.

* fix remove pokemon menu * fix dropdown all is not changing bug * fix bug when go down with no starter on start button * fix starter corsor bug on deletion. out of screen cursor bug * fix challenge log * fix lint error

… HA (pagefaultgames#3138) * Prevent evolution causing a swap from the second ability to the HA * Add tests * Update `starter-select-ui-handler.ts`

* More work * More work * Should be finished * Fixed an error in checking target * Moved white herb effect to StatChangePhase, 50% chance of consumption * Added graphics for White Herb * Balance and documentation * Add localization entry for White Herb apply msg * Add new keys to other localization files * German translations Co-authored-by: Jannik Tappert <[email protected]> * Update item sprite atlas * Redo item atlas * Remove whitespace in move.ts * Moved decrement outside conditional * Fix item atlas --------- Co-authored-by: Jannik Tappert <[email protected]>

…agefaultgames#3142)

DayKev · 2024-08-14T02:22:12Z

Can you fix the PR and then split this into multiple discrete challenges (ie: permadeath challenge, no auto-heal challenge, etc)?

flx-sta · 2024-09-17T16:38:11Z

@sirzento I'm putting this into draft while you resolve those conflicts and work on the open comments.

Are you actually still actively working on this?

DayKev · 2024-09-18T07:23:33Z

Ugh, trying to rebase this on current beta and it's just completely fucked. We really should have reverted the first beta merge and redid it correctly with rebasing...

DayKev · 2024-09-18T09:21:16Z

Now to check if I missed anything when manually copying the changes...

DayKev · 2024-09-18T10:43:47Z

Draft update at #4311

flx-sta · 2024-09-18T15:00:13Z

@DayKev so should this one be closed in favor of yours?

DayKev · 2024-09-18T15:05:47Z

@DayKev so should this one be closed in favor of yours?

Probably? I guess since the history is broken in this one it can't be used regardless.

f-fsantos and others added 3 commits June 19, 2024 17:31

refactor: Add missing properties to initLoggedInUser function

dbb1fc1

Added basic nuzlocke challenge

ee50de0

Madmadness65 added the Enhancement New feature or request label Jun 19, 2024

sirzento and others added 8 commits June 20, 2024 18:44

Added catch rule to nuzlocke challenge. Added additional data to chal…

0f4c26b

…lenge save game

Added localization and changed challenge UI to a fitting size

deb4be4

Update src/locales/de/menu-ui-handler.ts

ef5847d

Co-authored-by: Jannik Tappert <[email protected]>

Merge branch 'main' into nuzlocke-challenge

110d904

Changes localization. Merge Bugfix. Added new parameter to ADD_POKEMO…

d2ee63f

…N_TO_PARTY.

Added illegal move check. Added illegal move check to nuzlocke challenge

d514e6b

Added achievement image and localization

bd1b888

Fixed wrong UI label

426e5d2

sirzento marked this pull request as ready for review June 24, 2024 10:11

sirzento and others added 7 commits June 24, 2024 19:23

Added harcore difficulty to nuzlocke challenge. Removed no heal phase…

ad2f861

… from regular challenge.

Fixed achievement description

5c9e3a5

Description fix

924ff4e

Merge branch 'main' into nuzlocke-challenge

698910b

make i18n debugging an optional env setting

782718c

this also reduces output noise in tests

set development default also to "0"

e929538

Fixed Bug where shop items didn't match the function they have. Fixed…

400b807

… a bug that lets random forbidden items spawn.

sirzento added 2 commits June 29, 2024 12:01

Added localization.

29abe6b

Merge branch 'main' into nuzlocke-challenge

e54e75d

CodeTappert added the Game Balance Changes focused on game balance label Jul 5, 2024

sirzento changed the base branch from main to beta July 10, 2024 17:13

torranx and others added 2 commits July 10, 2024 13:48

fix inaccurate docs for TypeImmunityAbAttr (pagefaultgames#2957)

ff1fa15

chore: Add beta branch to GitHub Actions tests workflow

c44b38c

frutescens and others added 16 commits July 24, 2024 15:25

[Localization] Correctly Localized German names of the BGM for Evil T…

f3a98ef

…eams (pagefaultgames#3124)

[Misc] Change fresh start achievement icon to reviver seed

3caa51b

Mystic ticket icons in the achievements just confuse players

[Balance] Fix N-Solarizer etc appearing without secondary mon registe…

64d9c11

…red in dex (pagefaultgames#2713) * Fix reins et al being available without unlocking second mon * Small fix * Parentheses for safety * Add documentation to new function

Bug Fix (pagefaultgames#3129)

45d9c65

Co-authored-by: Frutescens <info@laptop>

[Bug] fix and condition of shiny and passive (pagefaultgames#3136)

29a5dd0

Fixed form names not working in starter select (pagefaultgames#3139)

2d51fc5

[Bug] Prevent evolution causing a swap from the second ability to the…

9f01b52

… HA (pagefaultgames#3138) * Prevent evolution causing a swap from the second ability to the HA * Add tests * Update `starter-select-ui-handler.ts`

[Localization] Translated missing portuguese entries and some fixes (p…

a604e00

…agefaultgames#3142)

Merge branch 'beta' into nuzlocke-challenge

6d5fb91

f-fsantos force-pushed the beta branch from 4bfa0e6 to 8a883ea Compare July 28, 2024 16:32

flx-sta added the Challenges Challenge mode/s related label Aug 2, 2024

sirzento dismissed CodeTappert’s stale review via 6d5fb91 August 25, 2024 17:12

flx-sta removed the request for review from Xavion3 September 17, 2024 16:37

flx-sta marked this pull request as draft September 17, 2024 16:38

DayKev mentioned this pull request Sep 18, 2024

[Challenge] Add Nuzlocke-related challenges #4311

Draft

9 tasks

DayKev closed this Sep 18, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Enhancement][Challenge] Nuzlocke challenge #2421

[Enhancement][Challenge] Nuzlocke challenge #2421

sirzento commented Jun 19, 2024 •

edited

Loading

Corrade commented Jun 20, 2024

sirzento commented Jun 20, 2024

hayuna commented Jun 29, 2024 •

edited

Loading

sirzento commented Jun 29, 2024

DayKev commented Aug 14, 2024

flx-sta commented Sep 17, 2024

DayKev commented Sep 18, 2024

DayKev commented Sep 18, 2024

DayKev commented Sep 18, 2024

flx-sta commented Sep 18, 2024

DayKev commented Sep 18, 2024

[Enhancement][Challenge] Nuzlocke challenge #2421

[Enhancement][Challenge] Nuzlocke challenge #2421

Conversation

sirzento commented Jun 19, 2024 • edited Loading

What are the changes?

Why am I doing these changes?

What did change?

Screenshots/Videos

How to test the changes?

Checklist

Corrade commented Jun 20, 2024

sirzento commented Jun 20, 2024

hayuna commented Jun 29, 2024 • edited Loading

sirzento commented Jun 29, 2024

DayKev commented Aug 14, 2024

flx-sta commented Sep 17, 2024

DayKev commented Sep 18, 2024

DayKev commented Sep 18, 2024

DayKev commented Sep 18, 2024

flx-sta commented Sep 18, 2024

DayKev commented Sep 18, 2024

sirzento commented Jun 19, 2024 •

edited

Loading

hayuna commented Jun 29, 2024 •

edited

Loading