Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aistack_basic test #20427

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

aistack_basic test #20427

wants to merge 1 commit into from
+648 −4

Conversation

yarunachalam
Copy link
Contributor

  • Verification run:WIP

@github-actions GitHub Actions
Copy link

Great PR! Please pay attention to the following items before merging:

Files matching lib/**.pm:

  • Consider adding or extending unit tests in t/

This is an automatically generated QA checklist based on modified files.

@yarunachalam yarunachalam mentioned this pull request Oct 18, 2024
Closed
@yarunachalam yarunachalam force-pushed the aistack_basic branch 8 times, most recently from 3b1407a to f45aa4f Compare October 18, 2024 19:22
m-dati
m-dati reviewed Oct 18, 2024
View reviewed changes
Copy link
Contributor

@m-dati m-dati left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debug lines Not needed, info already printed before

m-dati
m-dati reviewed Oct 18, 2024
View reviewed changes
tests/publiccloud/aistack_basic.pm Outdated Show resolved Hide resolved
tests/publiccloud/aistack_basic.pm Outdated Show resolved Hide resolved
m-dati
m-dati reviewed Oct 18, 2024
View reviewed changes
tests/publiccloud/aistack_basic.pm Outdated Show resolved Hide resolved
tests/publiccloud/aistack_basic.pm Outdated Show resolved Hide resolved
tests/publiccloud/aistack_basic.pm Outdated Show resolved Hide resolved
@yarunachalam yarunachalam force-pushed the aistack_basic branch 9 times, most recently from 7ff4edd to 0a292a9 Compare October 19, 2024 03:49
@m-dati
Copy link
Contributor

m-dati commented Nov 14, 2024

CI failed for tidy missing: check tidyness before to push

@yarunachalam yarunachalam force-pushed the aistack_basic branch 23 times, most recently from 62e7e84 to d63f50c Compare November 17, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-dati m-dati m-dati requested changes

@foursixnine foursixnine foursixnine requested changes

@mloviska mloviska Awaiting requested review from mloviska mloviska is a code owner

@jlausuch jlausuch Awaiting requested review from jlausuch jlausuch is a code owner

@pdostal pdostal Awaiting requested review from pdostal pdostal is a code owner

@grisu48 grisu48 Awaiting requested review from grisu48 grisu48 is a code owner

@ricardobranco777 ricardobranco777 Awaiting requested review from ricardobranco777 ricardobranco777 is a code owner

@asmorodskyi asmorodskyi Awaiting requested review from asmorodskyi asmorodskyi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yarunachalam @m-dati @foursixnine @ricardobranco777 @asmorodskyi