Included Private ai stack basic sanity test #20015

yarunachalam · 2024-08-20T18:58:05Z

Related ticket: https://jira.suse.com/browse/SUSEAI-8
Verification run: waiting for job template PR to be merged. So, I can do verification run

tests/publiccloud/aistack_basic.pm

m-dati · 2024-08-22T07:38:07Z

From what was used in pub.cl. and containers tests, it could be that this code flow could be rewritten in other way.
I mean that pre-installation of containers in publiccloud tests already are available in our tests after prepare_instance , registratio, ssh_interactive_start, etc... See i.e. OSD:Pub.Clo. Latest->publiccloud_container tests.

Probably it is useful some study on those test modules structures before this changes, unless a new project is ongoing, that I am not aware :)

@asmorodskyi comments would be useful here.

m-dati · 2024-08-22T13:00:38Z

Please check C.I. failing for some syntax to tidy.

m-dati · 2024-08-22T13:03:18Z

Please, see here below a summary of my suggestions and notes:

Taking as basic similitude the code in tests/publiccloud/run_ltp.pm:

on top of module I see probably missing the @_ input parameter initialization:
my ($self, $args) = @_ (eventually then remember $self->item ...);
in place of select_serial_terminal(), I'd suggest the use of its wrapper publiccloud::ssh_interactive -> select_host_console(), including more checks.
like runltp L99, suggested the "if-branch instance assignment from input, otherwise creation when not available" ($qam empty by default will run creation).
using n.3, then run registercloudguest($instance) with checks like in run_ltp.
be aware if the system would be transactional you need to add dedicated install (tr-up) and reboot actions, being Private-AI defined on SL micro.

tests/publiccloud/aistack_basic.pm

m-dati · 2024-08-23T09:30:20Z

tests/publiccloud/aistack_basic.pm

+    my $instance;
+    select_host_console();
+
+    my $aws_test = get_var('PUBLIC_CLOUD_AWS_TEST', 'basic_sanity');


Being (Private) AI the effective context needing such test, IMHO related parameters should also evoke and reference to AI, having for publiccloud specific parameter with similar meanings.
This is why I suggest here and elsewhere needed in that project, a different name than ...AWS_TEST, where even AWS could in future be another CSP, to be more related to the AI project.
It should mean: p.c.instance available/1 or not/0, like i.e. longer but clear PUBLIC_CLOUD_INSTANCE_FOR_AI or else (and variable updated too, accordingly, like i.e.: $has_instance 🙂).

Note: here we should use PUBLIC_CLOUD_QAM created for that instance status scope, but let we create a new one to keep separated AI project activities.

tests/publiccloud/aistack_basic.pm

m-dati · 2024-08-23T10:13:56Z

tests/publiccloud/aistack_basic.pm

@@ -0,0 +1,89 @@
+use Mojo::Base 'publiccloud::basetest';


CI still claiming tidy not ok.
Before to push your changes I suggest to run in your local repo the command tools/tidy <path/to/changed_file> (eventual issue, add ... --force)

m-dati · 2024-09-24T10:38:49Z

The CI detected tidy missing, see i.e. L#16 in function call's space before arguments and many similar other.
Needed: tools/tidy tests/publiccloud/aistack_basic.pm, rebase, push -f ...

yarunachalam · 2024-09-25T05:44:38Z

trigger job https://gitlab.suse.de/qac/gravity-cannon/-/merge_requests/81 in progress

m-dati · 2024-09-30T10:21:54Z

Sorry, still a comment about CI failure 😄

https://github.com/os-autoinst/os-autoinst-distri-opensuse/actions/runs/11027316476/job/30625398539?pr=2_0015#step:6:15 ,
about migration_autoyast.yaml and mau-extratests2.yaml errors;
https://github.com/os-autoinst/os-autoinst-distri-opensuse/actions/runs/11027316416/job/30625398972?pr=20015#step:5:17 ,
see the CI scheduled OOO test, the ssh -oBatchMode=yes: command not found and also see in previous results last passed is before your MR run, all other next failed: somethings in schedule.

m-dati · 2024-10-15T13:53:28Z

tests/publiccloud/aistack_basic.pm

+    }
+
+    registercloudguest($instance) if is_byos();
+    registercloudguest($instance) if (is_byos() && !$aws_ai_test);


It seems you didn't deleted previous line100 old-version 🙂 : typo?

m-dati · 2024-10-15T13:55:55Z

tests/publiccloud/aistack_basic.pm

+    #credentials from openwebui
+    #my $admin_username = get_var('OPENWEBUI_ADMIN');
+    #my $admin_password = get_var('OPENWEBUI_PASSWD');
+    #my $openwebui_hostname = get_var('OPENWEBUI_HOSTNAME');


Can those commented lines be deleted, unless you still need it for some reason?

m-dati · 2024-10-15T13:57:01Z

tests/publiccloud/aistack_basic.pm

+    #validate_openwebui($admin_username, $admin_password, $openwebui_hostname);
+    # Verify Ollama api endpoint
+    #verify_api_endpoint();
+    # Milvus DB Test
+    #milvus_db_test();
+    # Milvus DB Test
+    #milvus_db_test();
+    # OpenWebUI Integration test
+    #test_openwebui_interaction();


same comment as for commented lines: can we delete deactivated code?

m-dati · 2024-10-15T14:39:34Z

Please, note we that CI failiing may be related to missing module call, as mentioned in #20384 (comment).

github-actions · 2024-10-15T17:47:50Z

Great PR! Please pay attention to the following items before merging:

Files matching lib/**.pm:

Consider adding or extending unit tests in t/

Files matching lib/publiccloud/**.pm:

Provide VRs for both QE-C as well as QE-SAP (check Confluence for more info)

This is an automatically generated QA checklist based on modified files.

m-dati · 2024-10-17T16:28:56Z

tests/publiccloud/aistack_basic.pm

+#    - Create VM in EC2 SLE-Micro-6-0-BYOS.x86_64-1.0.0-EC2-Build1.36.raw.xz 
+#    - Installs required dependency to install aistack helmchart and containers 


One spaces here at each line end, to delete for C.I. tidy :)

yarunachalam · 2024-10-18T04:24:08Z

Closing this ticket and redirected the aistack test in new ticket #20427

yarunachalam requested review from pdostal, grisu48, asmorodskyi, ricardobranco777 and m-dati as code owners August 20, 2024 18:58

yarunachalam force-pushed the aistack branch 5 times, most recently from e445d4a to 997329e Compare August 21, 2024 17:30

rbmarliere reviewed Aug 21, 2024

View reviewed changes

tests/publiccloud/aistack_basic.pm Outdated Show resolved Hide resolved

yarunachalam force-pushed the aistack branch from 997329e to 39a80b7 Compare August 21, 2024 21:12

yarunachalam force-pushed the aistack branch from 39a80b7 to ba071b1 Compare August 22, 2024 17:34

m-dati reviewed Aug 23, 2024

View reviewed changes

tests/publiccloud/aistack_basic.pm Show resolved Hide resolved

m-dati reviewed Aug 23, 2024

View reviewed changes

tests/publiccloud/aistack_basic.pm Outdated Show resolved Hide resolved

m-dati reviewed Aug 23, 2024

View reviewed changes

yarunachalam force-pushed the aistack branch 3 times, most recently from 3d13356 to 52505e9 Compare September 24, 2024 01:21

yarunachalam force-pushed the aistack branch from 52505e9 to d478e33 Compare September 25, 2024 00:02

yarunachalam force-pushed the aistack branch from d478e33 to e575e3a Compare September 25, 2024 06:10

m-dati reviewed Oct 15, 2024

View reviewed changes

yarunachalam force-pushed the aistack branch from e575e3a to 89e991a Compare October 15, 2024 17:47

yarunachalam mentioned this pull request Oct 15, 2024

Included aistack test call #20384

Closed

yarunachalam force-pushed the aistack branch 3 times, most recently from 17b0172 to aaad262 Compare October 16, 2024 18:29

m-dati reviewed Oct 17, 2024

View reviewed changes

yarunachalam force-pushed the aistack branch from aaad262 to 9ac367d Compare October 18, 2024 03:33

yarunachalam requested review from mpagot, alvarocarvajald and BillAnastasiadis as code owners October 18, 2024 03:33

yarunachalam force-pushed the aistack branch from 9ac367d to dd2a36a Compare October 18, 2024 04:05

yarunachalam requested review from mloviska and jlausuch as code owners October 18, 2024 04:05

Included Private ai stack basic sanity test

18a92d3

yarunachalam force-pushed the aistack branch from dd2a36a to 18a92d3 Compare October 18, 2024 04:07

yarunachalam closed this Oct 18, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Included Private ai stack basic sanity test #20015

Included Private ai stack basic sanity test #20015

yarunachalam commented Aug 20, 2024

m-dati commented Aug 22, 2024 •

edited

Loading

m-dati commented Aug 22, 2024

m-dati commented Aug 22, 2024

m-dati Aug 23, 2024 •

edited

Loading

yarunachalam Sep 24, 2024

m-dati Aug 23, 2024 •

edited

Loading

yarunachalam Sep 25, 2024

m-dati commented Sep 24, 2024 •

edited

Loading

yarunachalam commented Sep 25, 2024

m-dati commented Sep 30, 2024 •

edited

Loading

m-dati Oct 15, 2024

m-dati Oct 15, 2024

m-dati Oct 15, 2024 •

edited

Loading

m-dati commented Oct 15, 2024

github-actions bot commented Oct 15, 2024 •

edited

Loading

m-dati Oct 17, 2024

yarunachalam commented Oct 18, 2024

		# - Create VM in EC2 SLE-Micro-6-0-BYOS.x86_64-1.0.0-EC2-Build1.36.raw.xz
		# - Installs required dependency to install aistack helmchart and containers

Included Private ai stack basic sanity test #20015

Included Private ai stack basic sanity test #20015

Conversation

yarunachalam commented Aug 20, 2024

m-dati commented Aug 22, 2024 • edited Loading

m-dati commented Aug 22, 2024

m-dati commented Aug 22, 2024

m-dati Aug 23, 2024 • edited Loading

Choose a reason for hiding this comment

yarunachalam Sep 24, 2024

Choose a reason for hiding this comment

m-dati Aug 23, 2024 • edited Loading

Choose a reason for hiding this comment

yarunachalam Sep 25, 2024

Choose a reason for hiding this comment

m-dati commented Sep 24, 2024 • edited Loading

yarunachalam commented Sep 25, 2024

m-dati commented Sep 30, 2024 • edited Loading

m-dati Oct 15, 2024

Choose a reason for hiding this comment

m-dati Oct 15, 2024

Choose a reason for hiding this comment

m-dati Oct 15, 2024 • edited Loading

Choose a reason for hiding this comment

m-dati commented Oct 15, 2024

github-actions bot commented Oct 15, 2024 • edited Loading

m-dati Oct 17, 2024

Choose a reason for hiding this comment

yarunachalam commented Oct 18, 2024

m-dati commented Aug 22, 2024 •

edited

Loading

m-dati Aug 23, 2024 •

edited

Loading

m-dati Aug 23, 2024 •

edited

Loading

m-dati commented Sep 24, 2024 •

edited

Loading

m-dati commented Sep 30, 2024 •

edited

Loading

m-dati Oct 15, 2024 •

edited

Loading

github-actions bot commented Oct 15, 2024 •

edited

Loading